Repository navigation
Ltp skipfile kirk - #643
Merged
Merged
Conversation
bhcopeland
approved these changes
Sep 23, 2026
A plain text skipfile never reaches kirk, so the tests in it still run. The -S option stores the path in SKIPFILE, but the kirk command line only uses SKIPFILE_PATH, and that one is set for yaml skipfiles only. So --skip-file is dropped and SKIPFILE is never read again. When kirk was added runltp was still the default, and runltp did read SKIPFILE. Only kirk users saw this. Dropping runltp made kirk the only runner, and now it hits everyone. Set SKIPFILE_PATH for the plain skipfile too and drop SKIPFILE. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
The check only runs for yaml skipfiles. A plain skipfile with a bad path goes straight to kirk, and kirk dies on it with a python traceback. Move the check out of the yaml branch so it covers both kinds. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
An absolute path to a yaml skipfile gets SCRIPTPATH glued in front of
it, so it ends up as ${SCRIPTPATH}//abs/path. That file can not exist.
The plain skipfile branch already checks for a leading slash. Do the
same for the yaml branch.
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
The -S option is parsed with nested ifs and string strip tests, three levels deep. Two of the comments only repeat the branch above them. So let's use a case instead. A case arm takes alternatives, so the http and the yaml test fit in one flat pattern, and the patterns say what the comments said. SKIPFILE_TMP can go too, wget writes straight to the skipfile variable. Do the relative path rule once after the option loop instead of in each branch. No functional change. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
roxell
force-pushed
the
ltp-skipfile-kirk
branch
from
September 23, 2026 13:23
37179e3 to
8145e58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.