Repository navigation
Fix Minecraft launch crash from Account refresh thread - #20
Merged
Merged
Conversation
- §§§ Account refresh notifications were raised off the UI thread; MainWindow marshals them into its DispatcherQueue and skips them after closing. - Per-subscriber failures no longer abort the refresh commit; all Account subscribers still receive updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Ran 57 targeted tests for authorization, session refresh, and game launch
Windows x64 builds successfully without warnings or errors
Windows build passes: MinecraftSessionCoordinatorTests, GameLaunchCoordinatorTests, AppCoordinatorTests, MicrosoftDeviceAuthTests
Verified regressed test now passes after fix
Tested account notification error handling and token rotation recovery
Main window notification processing validated through DispatcherQueue
Not run: End-to-end Minecraft launch testing after rebuild (requires manual verification)
Not run: macOS platform impact assessment (changes Windows-specific)
Not run: Full CI pipeline across both platforms (limited to Windows builds)