fix: resume interrupted dumps by checking existing file size#135
Open
Ghostedworld wants to merge 1 commit into
Open
fix: resume interrupted dumps by checking existing file size#135Ghostedworld wants to merge 1 commit into
Ghostedworld wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a dump is interrupted (power loss, crash, etc.), restarting
requires dumping the entire game from scratch even though most files
were already copied to USB.
The existing file-exists check in pfs.cpp had an uninitialized
variable bug —
byteswas used before being assigned, causingincorrect progress accounting.
Fix
Result
Interrupted dumps resume from where they stopped instead of
restarting from 0%.
Note
Untested on hardware due to lack of build environment.
Logic reviewed carefully — looking for someone to verify on device.