Skip to content

Preserve captures when the writer queue fills - #2

Merged
LightCyan01 merged 2 commits into
mainfrom
fix/preserve-writer-events
Oct 11, 2026
Merged

LightCyan01 merged 2 commits into
mainfrom
fix/preserve-writer-events

Conversation

@LightCyan01

@LightCyan01 LightCyan01 commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

Combat observations could be discarded when the writer reached its queue limit. The writer now waits for space, uses faster gzip compression during recording, and releases waiting callers if output fails. Capture construction is serialized before copying bodies or snapshots so concurrent callbacks do not accumulate detached data while waiting.

Preserve a single oversized record when the budget is empty, document the remaining storage and snapshot limits, and prepare version 1.3.2. The ZIP format and final compression remain compatible with existing recordings.

@greptile-apps

greptile-apps Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[High impact] The PR appears safe to merge; the previous memory-budget finding is addressed.

Summary

The PR preserves captures when the writer queue fills and prepares version 1.3.2.

  • Capture records wait for space instead of disappearing.
  • Capture callbacks build records one at a time.
  • Recording compresses gzip blocks faster.
  • The capture plugin is labeled version 1.3.2.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Callback arrives] --> B[Wait for observation gate]
    B --> C[Copy body or build snapshot]
    C --> D[Wait for writer space]
    D --> E[Queue record and release gate]
    E --> F[Writer saves record]
    F --> G[Release retained bytes]
    G --> D
Loading

Reviews (2) · Last reviewed commit: "Bound capture construction across concur..." · Reviewed by Greptile

Comment thread Sources/AtelierCapture/SessionWriter.cs
@LightCyan01
LightCyan01 merged commit 8f5cc47 into main Oct 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant