fix(wordpress): set plugin ownership before post-install commands#28
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
5c2ae58 to
a2f7b7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fix prevents startup crashes when a custom plugin post-install command needs write access to the plugin directory (for example, creating
integrations/ACFsymlink inpolylang-pro).Root cause
finalize_custom_plugin()was runningpost_install_commandsaswww-databefore adjusting ownership of the cloned plugin directory. Since cloning is done as root, some commands failed withPermission deniedand broke the bootstrap flow.Change
.docker/wordpress/entrypoint.sh, runchown -R www-data:www-data "$plugin_dir"beforerun_custom_plugin_post_install_commands.Validation
Permission denied,Fatal error,Class not found) and found none after the fix.