fix: embed PLUGIN_DIR in bash -lc command to survive login shell env reset#23
Merged
Conversation
…reset Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
post_install_commandsrun viabash -lc, the login shell sources/etc/profileand/etc/profile.d/*scripts which can discard variables exported by the parent process.Symptom:
$PLUGIN_DIRexpanded to empty, causing the Polylang Pro symlink command to target/integrations/ACFinstead of the full plugin path:Fix: embed the variable directly in the string passed to
bash -lcso it is set inside the login shell before the command runs:bash -lc "export PLUGIN_DIR='$plugin_dir'; $command"