🏷️ fix: Title an Open Live Card by Its Newest Label, Not a Line of Its Text - #16393
Merged
Merged
Conversation
1 task
danny-avila
force-pushed
the
danny-avila/expanded-live-header-label
branch
from
September 26, 2026 12:51
80dbc6b to
73e8444
Compare
danny-avila
added this pull request to stack #16396
September 26, 2026 14:10
danny-avila
force-pushed
the
danny-avila/expanded-live-header-label
branch
3 times, most recently
from
September 27, 2026 01:46
3bce802 to
0f1fe20
Compare
danny-avila
marked this pull request as ready for review
September 27, 2026 01:46
Base automatically changed from
danny-avila/live-reasoning-complete-sentence
to
dev
September 27, 2026 01:56
…s Text An open card whose label has not landed yet kept the live line, so its sticky header quoted the sentence the reader could already see streaming in the rows beneath it. Open, the header now names the span by its newest label: a thought's generated label or the generic thinking line, a batch label, a call's own line. Reasoning sentences and prose commentary are for the collapsed header, which stands in for rows the reader cannot see.
danny-avila
force-pushed
the
danny-avila/expanded-live-header-label
branch
from
September 27, 2026 01:56
0f1fe20 to
f1392f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An expanded live card whose phase label has not landed yet keeps its live header, and that header previewed the newest reasoning sentence. With the header pinned at the top while open (#16390), it quoted a line of the very thought streaming in the rows beneath it, so the reader saw the same text twice.
Open, the header now names the span by its newest label: a thought's generated
reasoning_label, or the generic "Thinking…" line until one lands; a batch label; a call's intent or generic line. Reasoning sentences and prose commentary stay the collapsed header's job, where they stand in for rows the reader cannot see.Stacked on #16392 and targets its branch.
How it works
getLiveActivitytakes apreferLabelsflag. With it set,newestLineskips a THINK part's sentence (falling through to its label or the generic line) and skips TEXT commentary entirely, so the walk continues to the nearest label or call.ActivityPhaseGrouppassesexpandedintoLivePhaseHeader, which sets the flag.Type of change
Testing
Automated tests:
ActivityPhaseGroup.test.tsx: collapsed card previews the newest finished sentence; open card is titled by the thought's label and does not carry the sentence; open card with no label falls back to the generic thinking linecd client && npx jest ActivityPhaseGroup LiveParity ContentParts.integration— 189 testsnpx tsc --noEmitinclient: no errors in touched filesBefore / after screenshot
Captured with the live card open after the first sentence completed. Before, the sticky header repeats that sentence above its visible thought; after, it titles the open card “Thinking...”.
118bbcf2e37c(before) →73e8444a82ac(after).