Handle empty backup test requests - #983
Conversation
The deployed June Lambda rejects the app's empty test request; upstream added probe support in August. Handle every HTTP header casing so probes consistently succeed without creating an empty backup. Exercise storage with a complete gzipped SQLite fixture and its independently recorded database digest, and document upgrading older deployments.
|
Thanks for opening a PR! A few things that help this get reviewed:
PRs that clearly don't follow these likely won't get reviewed in a reasonable timeframe. |
|
Thanks for this @cannontrodder I don't have an AWS account to test these changes so having you here fixing it up makes my day :)
Famous last words indeed. I'd love to make it simpler to run, but even right now it is not that friendly. I'd definitely be open to something like a "lambda mode" for the dotnet app which just handles a lambda request for backup and quits, but it's not in a great state ATM to have that setup |
The AWS reference implementation now handles the empty test request correctly when the probe header uses different casing.
Verified with upload/probe tests, API tests, build and formatting checks.
@LiamMorrow I see how you split the backends up so they can support particular features. What I might do is take a look at an AWS-hosted backend as well and see if there's a really cheap way to do it. If you've got that Docker container there, it shouldn't be too difficult, but those are famous last words.
This is all AI but I do always review it and I always write my own PRs for you.