Skip to content

fix(ci): resolve test regressions and runtime errors from merged PRs - #3416

Open
Lexus2016 wants to merge 5 commits into
mainfrom
fix/ci-merged-pr-checks
Open

fix(ci): resolve test regressions and runtime errors from merged PRs#3416
Lexus2016 wants to merge 5 commits into
mainfrom
fix/ci-merged-pr-checks

Conversation

@Lexus2016

@Lexus2016 Lexus2016 commented Sep 6, 2026

Copy link
Copy Markdown
Owner

Summary

This PR resolves multiple CI check regressions, runtime errors, and test failures discovered across recently merged PRs:

  1. run_agent.py: Fixed NameError in _spawn_background_review_now and _target_with_requeue by forwarding correction_hint and block_durable_writes in keyword arguments.
  2. hermes_cli/_subprocess_compat.py: Restored GIT_CONFIG_PARAMETERS="'core.fsmonitor=false' 'core.hooksPath=/dev/null'" in noninteractive_git_env to neutralize GitSpawn / CVE-2026-71963.
  3. model_tools.py & tools/tool_search.py: Added coerce_tool_args before deferred validation and enabled nullable parameter acceptance in validate_tool_args.
  4. tools/file_operations.py & tools/file_tools.py: Restored structured_error / _diagnostic propagation in PatchResult and patch_replace, fixed 4-space indentation defect in _suggest_similar_files, and integrated dynamic self-correction retry thresholds in patch_tool.
  5. tools/process_registry.py: Trimmed redundant description in action schema and synchronized valid action verbs (stop).
  6. tests/scripts/test_config_drift.py: Mocked _classify_write_access as "write" to prevent spurious test skips under CI.
  7. Test Shadowing Cleansing: Removed duplicate definition of test_api_server_hint_scopes_media_tag_guidance in test_prompt_builder.py and pruned 13 duplicate legacy definitions in test_tui_gateway_server.py.
  8. tests/test_model_tools.py: Explicitly enabled HERMES_TOOL_ARG_CONTRACT="1" in test_exception_returns_json_error.

All unit, regression, and schema probe tests pass locally.

- cli: fix missing and aliased noninteractive_git_env imports
- subprocess: fix duplicate env argument in bounded_probe_run
- config_migrations: deduplicate _migrate_to_38 functions to preserve relay plugin cutover
- scripts: resolve and fetch INSTALL_REF from local GIT_ROOT in dev-sandbox
- file_operations: restore ambiguous_match subclasses and other-bucket classifications
- tool_search: return not_found for unregistered tools and restore schema type validation
- tui_gateway: guard persist_user_* run_kwargs against incompatible signatures
- runtime_helpers: align AGENT_RUNTIME_POST_HOOK_TOOL_NAMES to canonical names and handle aliases
- tests: update cron loop guard, vacuum config, tool schema, and fuzzy describe assertions
@github-actions github-actions Bot added the fix Bug or fix label Sep 6, 2026
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

૮ >ﻌ< ა ci review

running on b330040 — ci: use standard windows-latest runner for windows-only test


Still running 1 job: Rust tests / cargo test (bootstrap installer)

❌ Job failures

OS-specific tests / Windows-only tests · View job

Job OS-specific tests / Windows-only tests failed.


⚠️ Action required

CI-sensitive file review · View job

This PR changes CI-sensitive files (eslint config, workflow YAMLs, or composite actions). These influence what the js-autofix job executes and pushes to main.

Sensitive files changed:

How to fix:

Add the ci-reviewed label after verifying:

  • no new eslint rules with custom fix functions that write outside linted paths,
  • no workflow changes that widen permissions or remove guards,
  • no composite action changes that alter what gets executed.

⚠️ Warnings

OSV vulnerability scan · View job

28 known vulnerabilities found in pinned dependencies.

How to fix:

Review the findings in the Security tab. Update the affected dependencies if a patched version is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Bug or fix security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant