Fix --exclude - #110
Merged
Merged
Fix --exclude#110
--exclude#110Conversation
This tests the `--exclude` option. The new scenario runs on all the examples but the ones in `using_dune` and `using_make`. Thus, it is equivalent to only running the examples in `docs`. The resuts contain a lot of false positives coming from the excluded directories, showing the option is broken.
The `reject_empty_and_curr` predicate was inverted. The false positives of the `--exclude` scenario are now fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #109 as suggested by @nojb.
A new test scenario
excludeis introduced to demonstrate the fix and identify future regressions.It runs on all the examples but the ones in
using_duneandusing_make. Thus, it is equivalent to only running the examples indocs.