Repository navigation
feat: Ride both velodromes on the island and meet other apps' riders on Herne Hill - #108
Conversation
…r apps Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A world with a route shared through OpenBikeNet had no bots at all. On the island that would empty every road, so only the shared routes go without. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A route with openbikenet now also names openbikenet_length, so a 450 m track scales as well as the 250 m one did with the fixed constant. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The outbox keeps each rider's route: one update carries riders on any route, and a rider who moves to another shared route leaves before joining it. The link subscribes to every route it shares. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…veryone A world can now hold several routes shared through OpenBikeNet, all on one link. Riders of other apps are shown to every rider of the world, nearest first, not only to those on the same track, and each track hands out its own ids. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e island Herne Hill Velodrome (450 m, OpenBikeNet herne-hill-450 and herne-hill-450-clockwise) joins the 250 m velodrome. All three stand on the island on the flat strip south of the valley-west road, off the road network, their home straights facing the road so a connector can join them later. tools/track-route.mjs writes all three. A sim test shows a track without a walk is ridden on a map with a network. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… round On a map with a road network the client drew only the network's roads, so the tracks would have been invisible. Map routes that aren't walks over the roads are now drawn and levelled like them. The start menu shows Herne Hill as one card, with a choice of the way round under its name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Reviewed at b1b8855. No blocking findings from this review. Checked the per-route bot exclusions (including event bots), multi-track subscriptions/outbox route changes, remote rider ID separation and placement, direction-card selection, and drawing/levelling tracks outside the road network. The remaining verification gap is already called out in the PR: the multi-track link has been exercised against the fake OpenBikeNet server, not the deployed service. A live interoperability smoke test is still needed to confirm all three subscriptions and riders appearing across apps after the OpenBikeNet deployment. From the code review and automated checks, this looks ready for approval. |
Why
Both velodromes should stand on the island, with Herne Hill Velodrome (OpenBikeNet/protocol#6) shared with other apps such as VeloPopuli, so everybody sees each other: riders on the roads, on the tracks, and in other apps (#107). Lanzarote stays a world of its own.
What changed
Server:
openbikenetnow also needsopenbikenet_length, which replaces the fixed 250 m.update. A rider who switches tracks leaves the old one before joining the new one.Routes:
herne-hill→herne-hill-450,herne-hill-clockwise→herne-hill-450-clockwise), 450 m, bend radius as in OpenBikeNet's GPS track.tools/track-route.mjs(wasvelodrome-route.mjs) writes all three tracks.mapvalley), on the flat strip south of thevalley-westroad, east and west of the river. They stay off the road network for now, but each home straight faces the road 35–50 m away at its height, so a connector road with junctions can be added later without moving them.Client:
Docs: ADR 0027 (amends 0020),
docs/protocol.md,docs/routes.md,docs/deploy.md,.env.example, README. Spec and plan indocs/superpowers/.The wire change only adds data, so
PROTOCOL_VERSIONstays the same. Breaking for self-hosters: a route file withopenbikenetbut noopenbikenet_lengthno longer loads.Not tested yet against a real OpenBikeNet server, only against the fake one in
tests/openbikenet.rs. The OpenBikeNet server already knows the Herne Hill routes (OpenBikeNet/server#6); it needsmake updateon the host.Screenshots
Start menu, Herne Hill picked clockwise:
Riding Herne Hill, drone view: the
valley-westroad and its riders behind:Riding the 250 m velodrome:
Checklist
make checkpassesfeat:,fix:,chore:, etc.) for squash merging: it becomes the release notedocs/protocol.mdandPROTOCOL_VERSIONfor protocol changes; an ADR for structural decisions)🤖 Generated with Claude Code