Repository navigation
feat: generate readable slugs for new newsletters - #33
Closed
leeclissett wants to merge 1 commit into
Closed
leeclissett wants to merge 1 commit into
leeclissett wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generate a readable, URL-safe slug from a newsletter's name when no custom URL is supplied.
This applies to both newsletters registered through the UI and newsletters automatically detected from incoming email.
Generated slugs:
/feeds/allroute and existing feed identifiersExplicit custom URLs continue to use the existing sanitization behavior.
Compatibility
Existing newsletters are not migrated or backfilled, so current feed URLs remain unchanged. Renaming a newsletter also leaves its existing slug unchanged. Names that cannot produce a safe ASCII slug continue to fall back to the newsletter ID.
Test coverage
Coverage includes:
Verification