Correct some type annotations - #930
Open
flaviut wants to merge 1 commit into
Open
Conversation
I noticed that some of the type annotations are either incomplete or out of date. This makes it harder to use the package correctly, since it's not possible to tell at build time that the API is correctly used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that some of the type annotations are either incomplete or out
of date. This makes it harder to use the package correctly, since it's
not possible to tell at build time that the API is correctly used.
Validation
This change was made with GPT-5.6, and I did both a manual review and leaned on the LLM to validate. I generated & ran the following comprehensive regression test: flaviut@3cb854b
Because this is only a type signature change, there is no possible impact on the logic of this package.