Repository navigation
fix(supabase): report errors from custom create/update/delete to onError - #675
Open
LinusOssmann wants to merge 1 commit into
Open
LinusOssmann wants to merge 1 commit into
LinusOssmann wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
wrapSupabaseFnis used for customlist,create,updateanddeletefunctions, but it always treats the first argument asparams:const { onError } = params. syncedCrud calls the write functions asfn(input, params), so for writesonErroris read from the row and isundefined. When a custom write returns{ error }, the wrapper throwsTypeError: onError is not a function. The user'sonErrorreceives that TypeError withsource: 'set'instead of the server error withsource: 'create'/'update', and there is norevert. Server rejections of custom writes (RLS, constraints, …) are effectively invisible.Fix
Keep the existing behavior for
list. For writes, takeonErrorfrom the second argument and route the error throughhandleSupabaseErrorwith the same params the built-in create/update/delete pass (type: 'set',input,revert).Test
tests/supabase-custom-fns.test.ts: a customcreateand a customupdatethat return an RLS error. OnmainonErrorreceives "onError is not a function"; with the fix it receives the server message, the rightsourceand arevertfunction.