Repository navigation
fix(supabase): merge realtime deletes in set mode - #670
Open
kerdofficial wants to merge 1 commit into
Open
kerdofficial wants to merge 1 commit into
kerdofficial wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #586
With
mode: 'set'and realtime enabled, a DELETE event was applied with the plugin'ssetmode, so the whole collection was replaced by{ [id]: Symbol(delete) }. INSERT and UPDATE already passmode: 'merge'; this does the same for DELETE.Added a test with a fake realtime channel: rows
aandb, deletea,bstays. It fails without the change.npm test,bun run buntest, lint, format, typecheck and build pass.