Repository navigation
fix: anchor data changes that arrive during a scroll-jump reset - #598
Open
chrispader wants to merge 1 commit into
Open
chrispader wants to merge 1 commit into
chrispader wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
After a large scroll jump, userScrollAnchorReset lets newly measured items reposition without an anchor until every item rendered since the jump is measured. When new data arrived in that window, the measurements of the new items pushed the visible items by a few hundred pixels for a frame. checkResetContainers now clears the reset when maintainVisibleContentPosition covers data changes, so the new data is anchored like any other data change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chrispader
force-pushed
the
fix/anchor-data-after-scroll-jump
branch
from
November 9, 2026 10:53
407e7dc to
823e44b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a large scroll jump, such as a fast scrollbar drag, LegendList lets newly measured items reposition without an anchor until it has measured every item it rendered since the jump. If new data arrives during that window, the measurements of the new items push the visible items by a few hundred pixels for a frame. With this change, a data change clears that state when
maintainVisibleContentPositioncovers data changes, so the new items are anchored like any other data change.We hit this in Expensify/App#100733, which moves the chat message list to LegendList. Dragging the scrollbar quickly to the top of a long chat makes the visible messages jump when the next page of older messages loads. Expensify currently carries this fix as a patch.
Reproduction
maintainVisibleContentPositionand estimated item sizes.