Repository navigation
fix: account for Android end clamping during item resizing - #582
Closed
chrispader wants to merge 2 commits into
Closed
chrispader wants to merge 2 commits into
chrispader wants to merge 2 commits into
Conversation
When measured content shrinks beyond the current offset, Android already clamps the viewport before native MVCP applies its anchor delta. Synchronize the JS offset to that clamp and request only the remaining movement so the same shrink cannot move the viewport twice. Keep data-change and active-target handling on their existing paths, and clamp targets to zero when the content fits the viewport.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Keep the upstream clamp implementation and its regression coverage, including the current shared scroll-range calculation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android, shrinking rows above the viewport can make native scroll clamping and MVCP apply the same movement twice. This accounts for the native clamp before applying the remaining item-size adjustment, including when the content shrinks to fit the viewport. It upstreams the second LegendList patch from Expensify/App#100733; #481 covers the related bottom-inset case.
Reproduction
native-content-shrinkfixture on Android with LegendList, MVCP enabled, and no bottom inset.