Skip to content

bug-report-py 3.2.0: ids of 6 or 12 hex; non-admins list features and their own reports - #32

Merged
kenatleap merged 2 commits into
mainfrom
feat/v3.2
Nov 15, 2026
Merged

kenatleap merged 2 commits into
mainfrom
feat/v3.2

Conversation

@kenatleap

Copy link
Copy Markdown
Collaborator

This is what LeapHQ's move to the central store needs. Ken decided both points on 2026-11-15 (decisions 1 and 3 in the LeapHQ plan).

What changes

  • Ids may end in 6 or 12 lowercase hex characters. LeapHQ's 64 reports use 12; new ids stay 6. The pattern is enforced in Python, Node and `openapi.yaml`, with a drift test that locks the three together.
  • Non-admins list feature requests plus their own reports, so anyone can see and vote on features.
    • A report they may not see answers 404, the same as a missing id, on detail, screenshot, vote and DELETE vote, so nobody can confirm a report exists.
    • Triage (PATCH) stays admin-only.
    • Visibility never falls back to `default_actor_email`. Emails are compared case-insensitively.
  • The Node backend enforces the new ids but keeps lists admin-only. That is documented, and the non-admin e2e case is Python-only, with the reason. No production app uses Node.

Tests (rerun by the coordinator in a fresh venv): Python + CLI 420, e2e 97 (with Postgres), Node 188/17/64, none failing.

  • `test_visibility.py` runs on every store, plus a Python e2e non-admin case.
  • Each test was shown to fail with its code broken (T4): hidden as 403 instead of 404, a screenshot or vote leak, the default-actor fallback, no case folding, 6-hex only, any length accepted.

Review (T1): done by a fresh reviewer. A caller with no email sees only features. The coordinator took two decide items conservatively:

  • a hidden report answers 404, not 403;
  • the Node backend is documented as admin-only for lists rather than ported.

Closed:

  • the default-actor fallback;
  • the e2e non-admin case;
  • 404s documented in the spec;
  • mixed-case, agent-filed and DELETE-vote cases;
  • an exact vote count;
  • the regex copies in the tests now import the library's check.

Tag `backends-v3.2.0` after merge.

🤖 Generated with Claude Code

kmoy007 and others added 2 commits November 14, 2026 21:52
…es and their own reports

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…r uses default_actor_email, Node documented as not ported

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@kenatleap
kenatleap enabled auto-merge (squash) November 15, 2026 06:04
@kenatleap
kenatleap merged commit d567c3e into main Nov 15, 2026
1 check passed
@kenatleap
kenatleap deleted the feat/v3.2 branch November 15, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants