Repository navigation
backends v2.2.0: closing a report emails the reporter; people are named - #25
Merged
Merged
Conversation
…named (bug-20261112-124952) Adds create_blueprint(notifier=, app_url=), PATCH notify, notified/canNotify, bug_report.email (render, AcsNotifier behind the [email] extra), actorName and changedByName, and identity-stamped changedBy. Node passes the fields through. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…; wait 30 s, not 60 LROPoller.result(timeout) returns what it last saw when the wait runs out (None or a Running status) instead of raising; check poller.done(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ariable - e2e/test_notify_http.py: a Python server with a stand-in mailer drives notify end to end (sent + audited, failed send still resolves, no notify sends nothing). Bites: dropping the _notify call fails 2 of 3. - tests/test_spec_drift.py: every field the server sends is in openapi.yaml. It found kind missing from BugSummary (older drift); added. Bites: renaming changedByName in the spec fails it. - report-contract.json reverted: it is mirrored byte-identically into five repos, and the new fields are optional; openapi.yaml carries them. - BUG_NOTIFY_CLIENT_ID picks the sending identity, not AZURE_CLIENT_ID, so it cannot change the identity the rest of an app signs in as. - CHANGELOG said the send wait was 60 s; it is 30. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server half of the approved close-email design (wire contract: bug-close-email CONTRACT.md). From Chris Hamblin's report bug-20261112-124952, which was fixed and then had to be relayed by hand.
create_blueprint(notifier=None, app_url="");PATCH {status, note, notify?}emails the reporter on a change to resolved/declined (never on reopen, needs a note), status change + audit row first, failed send never undoes it, second audit row records the outcome; response gainsnotified, GET gainscanNotify.bug_report.email:Notice,render(),AcsNotifier([email]extra, fail closed,retry_total=0, bounded wait,from_env()returns None when unset).actorName,changedByName;actor_identitymay return{email, name}; it now also stampschangedBy/changedByNameon PATCH.canNotify: false,notifyignored). Spec, types, openapi, report-contract (optional lists), e2e updated. py 2.2.0 + CHANGELOG.Not merged/tagged: coordinator tags
backends-v2.2.0after review.End-of-implementation review (fresh reviewer, 2026-11-13)
Closed in this PR, each with a test shown to fail when its fix is undone:
poller.done()check fails 2 tests.e2e/test_notify_http.py). Dropping the_notifycall fails 2 of 3.openapi.yaml(tests/test_spec_drift.py). It foundkindmissing (older drift), now added.report-contract.jsonwas reverted, because it is mirrored byte-identically in five repos and the new fields are optional.BUG_NOTIFY_CLIENT_ID.Settled by fact: the consumers' gunicorn timeout is 120 s, against the 30 s send wait.
Optional, not done:
LROPoller;Follow-up: when the fleet dashboard adopts names,
bug_store_pg.pymust addactor_nameandchanged_by_name.🤖 Generated with Claude Code