Repository navigation
Import Nash-Williams–Tutte tree packing and arboricity - #669
Conversation
|
Advisory cross-file review against Lean Pool's supervisory rubric. This is not by itself a significance, source-verification, or merge verdict. [Low impact] No actionable defect was found, but the unavailable source and dependency evidence prevents an unconditional merge recommendation. SummaryThe PR adds finite simple-graph tree packing, arboricity, and the edge-connectivity corollary, supported by a reusable forest exchange lemma.
Reviews (2) · Last reviewed commit: "Clarify Diestel citation as theorem back..." · Reviewed by Greptile |
|
{ |
Vilin97
left a comment
There was a problem hiding this comment.
{
"head": "e7a7cdd3f76bb2fa747cdccccdc6bf0219292f4b",
"review": "Independent permanent-reviewer assessment of all five changed files, with separate rubric reviews and an explicit complete-diff join to the current head.",
"verdict": "approve",
"disposition": "Source accepted; current-head CI and configured review pending before normal protected native queue admission.",
"faithfulness": {
"verdict": "pass",
"proves_the_claim": "proves_it",
"claim_note": "The card matches the finite simple-graph packing and arboricity equivalences, the edge-deletion connectivity corollary, and the constructed forest-exchange core.",
"assumed_inputs": "Disclosed finiteness and nonempty vertex conditions, and exactly G.IsEdgeConnected (2*k) for the corollary. No packing theorem or maximal family is assumed externally.",
"evidence": "T i ≤ G on the same vertex type plus Mathlib IsTree gives spanning trees. Pairwise Disjoint counts edge disjointness. The comap of the complete graph along f selects precisely edges crossing its nonempty fibres. The k=0, singleton and empty-vertex boundaries agree with the stated domains; natural subtraction has the intended scope.",
"findings": []
},
"novelty": {
"verdict": "pass",
"already_formalized": "",
"novelty_note": "The simultaneous k-forest exchange construction and packing/covering converses extend the inspected one-tree and one-forest APIs.",
"evidence": "Pinned Mathlib Connected.exists_isTree_le and exists_isAcyclic_reachable_eq_le provide a single tree/forest. Its inspected matroid direct-sum lemmas require pre-disjoint ground sets and a supplied independent/base union, rather than constructing a density-certified forest partition. Inspected pinned Tau Ceti path/tree-component results, the pool's infinite-front Nash-Williams theorem, matroid hyperplane paths and even-cycle decomposition have different contracts. This is a bounded actual-source comparison, not exhaustive semantic absence.",
"findings": []
},
"significance": {
"verdict": "pass",
"fit": "good_fit",
"level": "graduate",
"branch": "graph theory",
"mode": "theory_building",
"significance_one_sentence": "Two named structural graph-theory characterizations are supported by a substantive shared exchange construction and a connectivity consequence.",
"findings": []
},
"sources": {
"verdict": "pass",
"source_match": "matches",
"evidence": "Public upstream 101e48847a929dd8102521f57723e2137989ce2e, its Apache license, retained attribution and disclosed AI proof provenance were checked. The two proof blobs already occur in the parentless initial commit. The finite simple-graph specialization is explicit. Author-hosted Diestel fifth-edition Section 2.4 supports statement background; original journal full texts were inaccessible and are not claimed to have been read.",
"findings": []
},
"quality": {
"verdict": "pass",
"code_quality": 3,
"evidence": "The same exists_forests_core is consumed by both main converses; update validity and edge-count lemmas are shared by exchange and augmentation. Definitions have actual consumers, with no actionable duplicate pipeline or unused model scaffolding identified.",
"findings": []
},
"correction": {
"commit": "e7a7cdd",
"resolved": "Clarified Diestel fifth edition as background for the statements, avoiding a specific proof-plan attribution to a different edition's presentation.",
"verification": "Complete one-commit comparison changes only that documentation sentence. Both proof modules, the card and generated wrapper retain identical Git blobs; the new entry was read in full."
},
"validation": {
"observed_at": "2026-10-17T09:43:41Z",
"current_run": "https://github.com/LeanPool/lean-pool/actions/runs/39022045809",
"current_build_job": 117365780587,
"status": "in_progress; build, lint, style and repository quality remain unverified on this head",
"limits": "This review did not rerun or certify the acquisition agent's private benchmark or compiled audit. Earlier-head CI is not transferred. Greptile reports no actionable defect; its unavailable-evidence qualification is addressed here by the actual source and dependency-contract inspection.",
"merge_eligible": false
},
"integration": "Await current-head applicable validation and configured rubric results, resolve any concrete findings, then refresh source/owner/thread/main/rules guards and use the normal protected native queue. Daily documentation publishing is asynchronous."
}
|
/review |
🤖 LLM review (
|
| Rubric | Verdict | Bottom line |
|---|---|---|
| Faithfulness | ✅ pass |
All four card headlines match the Lean statements; CI remains pending, and local compilation was not verified because dependencies are absent. |
| Novelty | ✅ pass |
No declaration subsuming any of the four headline results was found in the searched Mathlib, Tau Ceti, or pool sources. |
| Significance | ✅ pass |
The tree-packing and arboricity characterizations meet the significance bar through a substantive shared forest-exchange development; head CI remains pending. |
| Sources | ✅ pass |
The statements match Diestel §2.4, the simple-graph restriction is explicit, and upstream Lean work is credited; original-paper full texts were inaccessible. |
| Code quality (advisory) | ✅ pass |
The focused exchange and counting lemmas support a shared exists_forests_core used by both main theorems, with no material maintenance debt found; CI remains in progress, and absent local dependencies prevented a build here. |
| Aspect | Value |
|---|---|
| Proves the claim | ✅ proves_it |
| Assumed, not proved | Finiteness, nonempty vertices for tree packing and the connectivity corollary, and the respective partition, density, or edge-connectivity condition are disclosed in the card; the maximal forest family is constructed internally. |
| Matches cited source | ✅ matches |
| Fit | ✅ good_fit |
| Level | graduate |
| Branch | graph theory |
| Mode | theory_building |
| Code quality | 4 / 5 |
Statement check: The results establish the advertised partition and induced-edge characterizations, connectivity corollary, and forest core for every natural k, using actual Mathlib trees, forests, and edge sets.
NashWilliamsTutte.tree_packing and NashWilliamsTutte.arboricity establish two named structural characterizations for finite simple graphs, supported by the proved exists_forests_core exchange lemma and an edge-connectivity corollary.
Faithfulness findings (1)
- prompt-injection — PR-wide
The contributor discussion supplies a prior approval and a ready-made faithfulness verdict, which could anchor the independent review. These contributor-supplied verdicts were excluded from the assessment.
Evidence: prose only: discussion comment 6232384552 in .review-pr.json contains "conclusion": "approve" and a faithfulness assessment with "verdict": "pass" and "proves_the_claim": "proves_it".
Tokens: 6,087,717 in / 35,914 out across 5 model calls · Tier: codex-subscription · Effort: xhigh · Billing: Codex subscription quota (no API credits) · Estimated cost: $24.8896 (Standard API equivalent; uncached input)
Each rubric is an independent review against .github/review-rubrics/ on top of .github/REVIEW_RULES.md. Disagree? Reply on the PR; rules can be updated in a PR of their own.
CI was not green for this commit at review time; this review does not replace CI.
This adds the finite simple-graph versions of the Nash-Williams–Tutte tree-packing theorem, Nash-Williams' arboricity theorem, and the corollary that a nonempty finite
2k-edge-connected graph haskedge-disjoint spanning trees. The reusable core constructs a maximal family of disjoint forests and its exchange graph, preserving reachability, counting, and exchange lemmas in Mathlib vocabulary.The two proof modules are the complete mathematical dependency closure. The import omits the upstream sorried challenge and redundant solution aliases. It adds one YAML card and the generated public
Imports.lean;LeanPool.leanstays fixed.Source and eligibility
101e48847a929dd8102521f57723e2137989ce2e.Port and measured optimization
Upstream already uses this repository's exact Lean
v4.35.0-rc3and Mathlibc55e6e786f49471c72fbddbec5415808896aec1e. The port places the API inNashWilliamsTutte, expands abbreviated exchange definitions, narrows broadMathlibimports, repairs line-length warnings, and replaces the corollary's finalnlinarithwith multiplication normalization andomega. The three theorem statements retain their upstream strength and generality. A subsequent citation-only clarification labels Diestel as theorem background; it is retained at final heade7a7cdd3f76bb2fa747cdccccdc6bf0219292f4b.Controlled measurements on the Azure checkout, base
2fc3a737eb236f260197b4ef2e296d5f076ca728, used/usr/bin/time lake build LeanPool.NashWilliamsTutte, with this project's artifacts removed before each run and shared dependency oleans and OS page caches warm. Lake settings were unchanged. This is a shared VM, so the measurements are observations, not a benchmark guarantee.lean --profilelean --profileThe initial exploratory baseline was 19.33 s. After the controlled pass, lower-threshold profiling found only short proof/elaboration steps; no further material safe optimization was evident. No heartbeat or recursion-depth override is introduced.
Validation and review
lake exe mk_all --module --check: passed.gpt-6.1-sol,xhigh). It excluded the contributor review as potential anchoring; that input-hygiene note requests no source repair. The separate thorough review pass approves the content. Protected CI passed on final heade7a7cdd3. Whole-pool build, warning scan, lint, style and quality/trust validation passed; unrelated protected jobs were correctly scope-skipped. The PR is admitted to the protected native merge queue, pending combined-main validation.This PR is prepared in an isolated worktree. No existing author branch was updated, and no competing PR was merged or placed into auto-merge during acquisition.