Skip to content

Retire public version-bump jobs in favor of private VM automation - #660

Open
Vilin97 wants to merge 3 commits into
mainfrom
fix/vm-version-bump
Open

Vilin97 wants to merge 3 commits into
mainfrom
fix/vm-version-bump

Conversation

@Vilin97

@Vilin97 Vilin97 commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Retire the public version-bump implementation in favor of the private Lean VM controller in Vilin97/lean-pool-automation#4.

Remove the GitHub-hosted Mathlib Bump workflow, its obsolete Claude-auth canary, the old release/pin helper and CI report renderer, and their moved tests. Keep only a short operator pointer in .github/BUMP_AUTOMATION.md. The runner, release tools, repair prompt, tests, installer and systemd units live in lean-pool-automation; no new VM code remains in the final public diff.

The private controller uses full Git ancestry to fix branch resumption, selects cx accounts by most remaining quota, preserves repairs across failover/restarts, and runs the existing build and quality gates before publishing a draft content PR. Public proof sources and quality rules are unchanged.

Validation: 32 migration tests and 55 existing automation tests pass locally and on the Lean VM; the private package starts with system Python without a public engine. Ruff, shell syntax and systemd verification pass. The previous live cx model/tool smoke test exercised a failed first account followed by a successful second account.

Deployment retains the same VM service/timer, checkout, caches and pending v4.35.0 checkpoint. Both retired GitHub workflows remain administratively disabled to prevent duplicate controllers while this cleanup is reviewed.

@Vilin97
Vilin97 marked this pull request as ready for review October 16, 2026 04:58
@greptile-apps

greptile-apps Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Advisory cross-file review against Lean Pool's supervisory rubric. This is not by itself a significance, source-verification, or merge verdict.

RetriggerView in Greptile

[Critical impact] The repository-side removals appear safe to merge.

Summary

Removes the public version-bump implementation and documents its ownership by the private lean-pool-automation repository.

  • Nightly version bumps now run from the Lean VM.

Reviews (2) · Last reviewed commit: "Move version-bump implementation and tes..." · Reviewed by Greptile

Comment thread python/lean_pool/bump_vm.py Outdated
@Vilin97 Vilin97 changed the title Move version bumps to the Lean VM with cx quota waterfall Retire public version-bump jobs in favor of private VM automation Oct 16, 2026
@Vilin97

Vilin97 commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator Author

Source review at exact head a2ea06c6873dc528e56ad2b525a9f8ddc6b35214: the current public cleanup is technically favorable within the inspected scope.

This head materially changes the earlier proposal. The final diff has six paths: a short operator pointer, deletion of the two hosted workflows, and removal of the old bump helper, its dedicated tests and CI summary renderer. The proposed public VM controller, its tests and systemd units are absent. My earlier controller analysis therefore does not become a change request against this head, or acceptance of its private replacement.

The complete public deletion diff and a bounded reference audit of all 17 retained workflows, both bump skills, package initialization/configuration, Python README and Makefile found no remaining executable invocation of the removed helper or renderer. The dedicated test and its removed helper form the same retired dependency chain; normal Python test discovery remains intact. A small documentation follow-up remains: the version-bump-project skill's description still says it is used by the retired workflow.

The private replacement's reported test results, draft-publication behavior and live service/checkpoint continuity remain owner evidence. They were not independently certified here, and I made no service, account, controller or branch changes.

Removing the two workflows still needs the separate direct authorization required by current CONTRIBUTING.md. This review assignment supplies no exception to its workflow-change rule. The current main 13797a3 also lacks exact-head Lean/documentation CI coverage, so the infrastructure priority hold remains. No queue admission, auto-merge, merge or approval is given.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant