Repository navigation
Import persistent quartic SOS counterexamples - #638
Conversation
|
{ |
|
Advisory cross-file review against Lean Pool's supervisory rubric. This is not by itself a significance, source-verification, or merge verdict. [Low impact] No blocking code issue remains, but external source fidelity and upstream completion still need verification before an unconditional merge recommendation. SummaryImports two fourteen-variable quartic SOS counterexamples with exact moment certificates and a companion with one global minimizer.
Reviews (2) · Last reviewed commit: "Generalize the moment bridge and correct..." · Reviewed by Greptile |
|
{ |
|
/review Current head: Source/completion evidence for the remaining Greptile caveat:
Recovery hold evidence is now complete: both PR610 and PR611 are merged; the last substantive main source commit |
|
{ |
🤖 LLM review (
|
| Rubric | Verdict | Bottom line |
|---|---|---|
| Faithfulness | ✅ pass |
All four card headlines match the Lean, with no undisclosed mathematical assumptions. |
| Novelty | ✅ pass |
No duplicate of the four headlines was found in pinned Mathlib, the pool, or inspected Tau Ceti declarations; novelty beyond the bounded Tau Ceti comparison remains unverifiable. |
| Significance | ✅ pass |
The completed research-level counterexamples justify the certificate bulk: 86.7% of code lines use elementary integer/Fin APIs, with a pinned upstream generator but no certificate regeneration command in this repository. |
| Sources | ✅ pass |
Both headline results match the credited upstream, and Cartis–Zhu Remark 2.3 has the stated scope; the Choi–Lam full text remains unverified. |
| Code quality (advisory) | ✅ pass |
The proof layers are coherent, and the generated certificates consistently reuse the Schur-step API without material maintenance debt. |
| Aspect | Value |
|---|---|
| Proves the claim | ✅ proves_it |
| Assumed, not proved | The counterexamples assume the disclosed parameter positivity; the quantitative bound assumes the proposed polynomial shift is SOS and permits arbitrary real b. The moment certificate, sphere bounds, localizers, and SOS summand degree bound are proved. |
| Matches cited source | ✅ matches |
| Fit | ✅ good_fit |
| Level | research |
| Branch | polynomial optimization and real algebraic geometry |
| Mode | mixed |
| Code quality | 3 / 5 |
Statement check: The explicit quartics attain the stated minimum and have non-SOS minimum shifts for every positive parameter triple; the companion uniquely attains it with positive definite polynomial Hessian, and the quantitative bound and moment-functional claims are also proved.
persistent_failure and unique_persistent_failure establish ordinary SOS gaps for every positive parameter, including a quartic with a unique nondegenerate global minimizer, addressing the regime raised in Cartis–Zhu, Remark 2.3.
Faithfulness findings (1)
- prompt-injection — PR-wide
Three contributor-authored discussion comments embed earlier reports asserting conclusion approve and faithfulness verdict pass; the /review request also says “It approves”. These prior-approval claims risk anchoring the independent review and were disregarded. Keep prior-verdict assertions out of automated review requests.
Evidence: prose only
Novelty findings (1)
- prompt-injection — PR-wide
The contributor invokes prior approval, which has no standing in this independent review and could substitute an asserted verdict for prior-art evidence.
Evidence: PR discussion issuecomment-6108077290 states: ‘It approves; the two earlier Greptile code findings were repaired and their threads resolved.’
Significance findings (1)
- prompt-injection —
.review-pr.json:1
The contributor discussion claims prior approval and supplies a complete significance pass verdict; treating these as review authority would compromise independence, so they were excluded from the assessment.
Evidence: comments[3].body states: “It approves; the two earlier Greptile code findings were repaired and their threads resolved.” Contributor review objects also contain an approve conclusion and a significance pass verdict.
Sources findings (1)
- prompt-injection — PR-wide
The contributor-supplied discussion claims prior approval and supplies a sources verdict, risking substitution of that verdict for independent citation review. Those claims were disregarded; the pinned sources were checked directly.
Evidence: Comments 6107787016, 6107891410 and 6108078565 contain "conclusion": "approve" and a sources verdict of "pass"; comment 6108077290 states: "It approves; the two earlier Greptile code findings were repaired and their threads resolved."
Tokens: 7,475,079 in / 67,256 out across 5 model calls · Tier: codex-subscription · Effort: xhigh · Billing: Codex subscription quota (no API credits) · Estimated cost: $30.9092 (Standard API equivalent; uncached input)
Each rubric is an independent review against .github/review-rubrics/ on top of .github/REVIEW_RULES.md. Disagree? Reply on the PR; rules can be updated in a PR of their own.
|
The automated review assessed the pinned source independently and passed all five rubrics at The exact CI-tested head is admitted to the normal protected native merge queue, position 1. No branch rebase or protection bypass was used. Merge-group checks remain the final integration gate. |
Adds an explicit 14-variable counterexample to eventual ordinary SOS exactness of Euclidean quartic regularization, together with a companion having a unique global minimizer and positive-definite Hessian there. Both results hold for every positive regularization, quadratic, and cubic parameter. This addresses the zero-gradient, negative-definite-Hessian regime of Cartis–Zhu, Remark 2.3 (https://arxiv.org/html/2601.20418v2#S2.SS3); it does not contradict their sufficient conditions with nonzero gradient or positive Hessian at the origin.
Source and eligibility:
d432ff9a67594cc0fa7a7af1913320b46d2a86db.verified/2026-10-10-unique-minimizerpoints at that commit. Upstream exact-head verification: https://github.com/JD-Jones-ASES/persistent-sos/actions/runs/38087401582.Disclosure.mdrecords Codex-assisted construction, proofs, certificate generation and Lean formalization, plus automated GPT-6 Pro review; the card therefore saysAI. The full MIT copyright/permission notice is retained in each adapted source. MIT permits sublicensing; the required Lean Pool Apache header is included without removing that notice.Scope and mathematical fidelity:
Imports.lean, plus one YAML card. Excludes the challenge holes, redundant solution wrapper, scripts, external verifier records and written supplements.LeanPool.leanis unchanged.IsSOSmeans an arbitrary finite sum of squares of real multivariate polynomials. The degree bridge proves that any summands in a quartic SOS representation have degree at most two; this is a theorem, not an assumption restricting SOS.Fin 14by inference.IsSumSqAPI and TauCeti's quadratic-form/tableau sum-of-squares results do not establish these quartic counterexamples.Port and measured optimization:
v4.35.0-rc3and the unchanged pool Mathlib pinc55e6e786f49471c72fbddbec5415808896aec1e./usr/bin/time -v lake build LeanPool.PersistentSOS.Validation:
sorry,admit,unsafe,partial, native reduction, resource overrides or suppressions.The separate thorough review at the final CI-tested head is recorded at #638 (comment). The configured automated review passed all five independent rubrics at that same head: #638 (comment) (reported model
gpt-6.1-sol,xhigh). Greptile reports no remaining blocking code issue; its source/completion caveat is addressed with the pinned upstream commit, verification run and primary source comparison above. The automated review disregarded contributor prior-verdict assertions; the/reviewrequest now supplies source evidence without such wording.The recovery hold was verified cleared before queue admission: PR610 and PR611 are merged, current main
7498a16d2393e1f02245cb265d67ec4fb2587814has a successful build gate, and the last substantive source commit has successful full build and documentation checks (only README updates intervened). This exact head entered the active protected native queue at 2026-10-11 11:06:52 UTC, position 1. Merge-group validation passed and GitHub merged the PR at 2026-10-11 11:23:32 UTC asba6537a7d5647d8cc9f88dcefe5c3dc77d1cb9b0: https://github.com/LeanPool/lean-pool/actions/runs/38134396764. All six merge-group workflows succeeded; unrelated jobs were skipped under the unchanged scope configuration. No protection bypass or author-branch rebase was used.Greptile identified two advisory issues, both repaired: the example has a negative-definite (not indefinite) Hessian at the origin, and the monomial moment bridge can be general in its variable type/coefficient semiring. Rebuilt all dependent endpoints, reran declaration/style linters and axiom/environment audits; theorem strength is preserved.