Repository navigation
fix: preserve YAML project cards regardless of key order - #532
Merged
Merged
Conversation
|
Advisory cross-file review against Lean Pool's supervisory rubric. This is not by itself a significance, source-verification, or merge verdict. [Medium risk] Changes how YAML project cards are parsed and split. The PR appears safe to merge; no new actionable issue was identified. SummaryThe PR replaces first-key-based card detection with YAML sequence boundaries, preserving cards with reordered keys or standalone sequence markers. It adds regression tests for those layouts and for the real registry. Reviews (2) · Last reviewed commit: "fix: recognize standalone YAML sequence ..." |
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-rebase silently dropped newly added project registrations when a YAML card began with
title:rather thanslug:. Parse the YAML sequence and use its source positions to preserve each card verbatim, independently of key order, quoting, or indentation. Reject ambiguous identities and unsupported layouts before writing a merged registry.Validation: all 450 Python tests pass, including 35 rebase tests covering the reported loss, quoted identities, standalone sequence markers, nested lists/block scalars, duplicate and missing slugs, and byte-for-byte coverage of the actual project registry. Ruff lint, formatting, and
git diff --checkpass.The fixed parser also round-trips all 46 currently labeled PR registries without losing or rewriting any card.