Repository navigation
Conversation
…d complete production scope
Changes requested by automated reviewReviewed exact head |
|
/review |
|
Advisory cross-file review against Lean Pool's supervisory rubric. This is not by itself a significance, source-verification, or merge verdict. [Low risk] Adds mathematical library code for class field theory. No new blocking defect was established; this incomplete review does not establish that the PR is safe to merge. Findings
SummaryAdds class field theory modules, public import indexes, and a project card naming local and global reciprocity as its main results.
Reviews (2) · Last reviewed commit: "Merge current main and migrate PR #506 t..." · Reviewed by Greptile |
| github_repo: n-yamaguchi-0729/ClassFieldTheory | ||
| commit: 01b4614ee76fa6f50e7f3ea3e1cff93b85693345 | ||
| license: Apache-2.0 | ||
| status: verified |
There was a problem hiding this comment.
The new project entry ends with status: verified but does not declare whether its Lean proofs have human, AI, or mix provenance. This violates the contribution directive that every project card must classify proof provenance, so the repository requirement must be satisfied before merging.
File Used: CONTRIBUTING.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
🤖 LLM review (
|
| Rubric | Verdict | Bottom line |
|---|---|---|
| Faithfulness | ✅ pass |
Both card headlines match their Lean statements, with no undisclosed substantive assumptions found. |
| Novelty | ✅ pass |
Searches of pinned Mathlib 4.34.0 and the existing pool found no duplicate of either headline reciprocity theorem. |
| Significance | ✅ pass |
The local and global reciprocity and existence theorems constitute a substantial theory-building project suitable for the pool. |
| Sources | ✅ pass |
The explicitly credited pinned upstream source supports the claimed results; no citation mismatch or uncredited formalization was identified. |
| Code quality (advisory) | 🤔 discuss |
The code is broadly competent, but duplicated proofs and unused private transfer helpers warrant a cleanup pass. |
| Aspect | Value |
|---|---|
| Proves the claim | ✅ proves_it |
| Assumed, not proved | The local theorem assumes a finite abelian Galois extension of a nonarchimedean local field; the global theorem assumes a number field, consistent with the card’s scope. The internal class-field axioms are proved and supplied by constructions, not assumed by the headlines. |
| Matches cited source | ✅ matches |
| Fit | ✅ good_fit |
| Level | graduate |
| Branch | algebraic number theory |
| Mode | theory_building |
| Code quality | 3 / 5 |
Statement check: Local reciprocity supplies a continuous surjective homomorphism with precisely the field-norm kernel; global reciprocity supplies the stated topological group isomorphism for number fields.
Develops class field theory through reciprocity and classification of abelian extensions, with major results including Hasse–Arf, the cyclic Hasse norm theorem, and Kronecker–Weber.
Code quality findings (2)
- duplicate-proof —
LeanPool/ClassFieldTheory/ClassFieldTheory/GlobalClassFieldTheory/Reciprocity/CyclotomicUnramifiedGeometricRestriction.lean:659
This private restriction lemma duplicates the statement and proof ofrestrictNormalHom_infiniteGlobalArtinMonoidHom_of_scalarTowerinInfiniteGlobalArtin.lean:728, which is already transitively imported.CyclotomicUnramifiedLocalGlobalCompatibility.lean:92repeats the argument again after applyingMonoidHom.ext. Another substantial duplication is the bounded-naturals proof inValuation/AbsoluteValue/Nonarchimedean.leanandValuation/AbsoluteValue/Theory/AbsoluteValues.lean, including the binomial estimate, root bound, and limiting argument. Share these implementations and retain thin interface lemmas; otherwise API changes require repairing multiple copies.
Evidence: The privaterestrictNormalHom_infiniteGlobalArtinMonoidHom_of_towerand publicrestrictNormalHom_infiniteGlobalArtinMonoidHom_of_scalarTowerboth concludeAlgEquiv.restrictNormalHom E (infiniteGlobalArtinMonoidHom K Ω a) = globalArtinMonoidHom (K := K) (L := E) a := byand start withlet j : E →ₐ[K] Ω := IsScalarTower.toAlgHom K E Ω. The third copy followsapply MonoidHom.ext; intro a. In the absolute-value files,private theorem add_le_root_bound_of_bounded_natat line 145 andtheorem add_le_root_bound_of_bounded_natat line 624 have identical statements and bodies, includingrw [Real.mul_rpow hcoef_nonneg (pow_nonneg hM_nonneg n)]andrw [Real.pow_rpow_inv_natCast hM_nonneg hn]. - dead-code —
LeanPool/ClassFieldTheory/ClassFieldTheory/AbstractClassFieldTheory/Reciprocity/Construction/MainTransferFrobenius.lean:922
BothtransferNormNaturalityTransferNormFiber_sumhere andtransferNormNaturalityNorm_eq_sum_transferOrbitRepresentativesat line 100 are substantial private lemmas with no references or automation attributes. The finaltransferNormNaturalityNorm_eq_sum_transferNormsinstead reconstructs their norm-expansion and reindexing arguments. Use the helpers in that proof or remove the unused variants so maintainers do not have to preserve parallel, inaccessible implementations.
Evidence: The diff declaresprivate theorem transferNormNaturalityNorm_eq_sum_transferOrbitRepresentativesandprivate theorem transferNormNaturalityTransferNormFiber_sum; each name occurs only at its declaration. The latter proof containsrw [relativeNorm_apply_coe, relativeNormValue]and finishes withexact Internal.transferNormNaturalityTransferNormFiber_term D A E L hL σ q π hSβC kq. The final public theorem repeats that rewrite and concludes the corresponding calculation withexact Internal.transferNormNaturalityTransferNormFiber_term D A E L hL σ qT π hSβC kq.
Tokens: 4,166,841 in / 34,996 out across 5 model calls · Tier: codex-subscription · Effort: xhigh · Billing: Codex subscription quota (no API credits) · Estimated cost: $85.9615 (Standard API equivalent; uncached input)
Each rubric is an independent review against .github/review-rubrics/ on top of .github/REVIEW_RULES.md. Disagree? Reply on the PR; rules can be updated in a PR of their own.
CI was not green for this commit at review time; this review does not replace CI.
# Conflicts: # LeanPool.lean
Changes requested by automated reviewReviewed exact current head |
Changes requested by automated reviewReviewed head
Review coverage: complete changed-file inventory and full diff retained; 1821 changed project files, 519,861 lines, import reachability and executable trust-token scan; advertised endpoints and supporting definitions examined with bounded implementation sampling and existing review findings reconciled. Potential reusable value: Local/global class-field and cyclotomic infrastructure. Source/provenance and prior-art evidence were considered separately from CI; these findings do not assert that every proof line was manually read. Earlier automated scores are advisory and are not approval of this failing head. Exact-head reconciliation: the automatic main merge left all project Lean source and the pinned toolchain unchanged. This run restored the original parsed project card after the rebase parser dropped the title-first entry; parsed-card equality and the generated module-index check pass. The restoration is a narrowly scoped fast-forward commit from an isolated worktree. It does not repair the substantive blockers above; new CI is not assumed green. |
# Conflicts: # LeanPool/projects.yml
# Conflicts: # LeanPool/projects.yml
# Conflicts: # LeanPool/projects.yml
# Conflicts: # LeanPool/projects.yml
# Conflicts: # LeanPool/projects.yml
# Conflicts: # LeanPool/projects.yml
# Conflicts: # LeanPool/projects.yml
# Conflicts: # LeanPool/projects.yml
# Conflicts: # LeanPool/projects.yml
# Conflicts: # LeanPool/projects.yml
# Conflicts: # LeanPool/projects.yml
# Conflicts: # LeanPool/projects.yml
# Conflicts: # LeanPool/projects.yml
# Conflicts: # LeanPool/projects.yml
# Conflicts: # LeanPool/projects.yml
# Conflicts: # LeanPool/projects.yml
Preserve authored mathematics and metadata; regenerate public project indexes.
Imports all 1,655 source modules from n-yamaguchi-0729/ClassFieldTheory, represented by 1,822 pooled Lean files. The scope includes local and global class field theory, reciprocity, Lubin–Tate theory, ramification, and the required Galois-cohomology and valued-field libraries. Original copyright and author notices are retained under Apache-2.0.
The port preserves the source statements and uses the repository's module system; norm, fixed-field, ramification, and cohomology proofs have been factored without dropping the original statements. The source index covers all 1,822 pooled files.
Current published head (2026-10-01):
90e7949e44cc7cd7f8db817f01884d28466c9965contains the automatic merge of currentmainand its compact generated project-root index. The old aggregate-index line-cap failure is resolved. Protected CI for this head is running or queued; its final result is not yet known. The prior hosted build reported proofwhnftimeouts inFixedFieldLocalDataandIdeleClassDirectLimitExtensionplus a dependent unknown theorem.The local Lean 4.35.0-rc3 worktree has eleven unpushed source repairs. The corrected norm-quotient module passed a scoped exact build; a source-guarded diagnostic is locating the remaining fixed-field timeout. Structural timeout repairs, full build, declaration/style lint, compiled axiom audit, and final-head checks remain outstanding. The local card now records
provenance: mix, based on the upstream authorship and AI-assistance disclosure; that card edit is not yet published. Gates, limits, compiler options, and waiver settings are unchanged.Part of the requested 42-project import batch. Do not merge yet.