Skip to content

Import continuous-path Markov process development - #473

Merged
Vilin97 merged 43 commits into
mainfrom
codex/import42-markovprocess
Sep 28, 2026
Merged

Vilin97 merged 43 commits into
mainfrom
codex/import42-markovprocess

Conversation

@Vilin97

@Vilin97 Vilin97 commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

Imports the complete production Lean development from Scott Armstrong's MarkovProcess repository into LeanPool.MarkovProcess, pinned to that source revision and ported to Lean/Mathlib 4.34.0. It retains all 250 upstream production Lean files and their proved solution bridges; the pooled project has 267 Lean files after the module and shared-helper repairs. The project card records Apache-2.0 attribution and AI provenance.

The principal result constructs a unique continuous-path Markov kernel for a conservative Feller transition semigroup under a uniform Kolmogorov displacement-moment bound. Supporting developments cover strong Markov properties, generators and resolvents, stopping and killing, and Brownian motion. The import does not include duplicate open challenge statements, audit harnesses, documentation consumer examples, or the upstream build configuration; their proved production declarations remain in the project.

The 267 project files and raw project card are byte-identical to the accepted source revision 3a601a611fcec66e150c21065d32e659f0ee08ca. The pinned upstream LICENSE, card, and all imported Lean headers identify Apache-2.0. The earlier advisory MIT note cited a line in another project's card.

The source-identical head ac25e15f87099ecd4b0f233f7c29b3c1f4047213 passed the hosted full-pool build, challenge build, declaration and text-style linters, repository quality checks, and protected checks. This integration commit 5ceea7e976199e36488df20a64d6e998538f8f54 preserves all 267 MarkovProcess files, all 235 pre-existing main project cards and other main paths, and the complete sorted index at main f4274ced69c745bd18d0ae53bcce3f0c4f0a9072. Fresh exact-head CI and strict clean mergeability remain required before merging.

@github-actions

Copy link
Copy Markdown
Contributor

Proof profile (new / modified Lean files)

No proof profile output.

@Vilin97

Vilin97 commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

Automation disposition: needs-maintainer

Reviewed exact head 771190e64c61056d0478c5087feea9e1155335cf for this draft pooled-project/content import, WIP: Import markovprocess. The changed tree is a substantial source import (for example LeanPool/MarkovProcess.lean) with the pinned upstream source, project metadata, and generated index present. Observed exact-head required checks have no failures; profile evidence is not posted for this head.

No concrete author-actionable defect was established in this bounded review that would justify an ordinary change request. The PR is still marked draft, so protected merge is not permitted. Maintainer decision required: confirm the headline result's significance, faithfulness, novelty, source/provenance and scope, then ask the author to mark the PR ready (or give scope direction). This is a maintainer disposition, not an approval.

@Vilin97 Vilin97 added the needs-maintainer Actual human decision required: licensing, mathematical scope, policy, or reviewer disagreement. label Sep 22, 2026
@Vilin97
Vilin97 marked this pull request as ready for review September 23, 2026 06:10
@Vilin97

Vilin97 commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator Author

/review

@greptile-apps

greptile-apps Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Advisory cross-file review against Lean Pool's supervisory rubric. This is not by itself a significance, source-verification, or merge verdict.

Retrigger

[Low risk] Adds a new mathematical library module for Markov processes.

The PR should not merge until the new BicausalOT verification claims are supported or corrected.

Summary

The PR imports the MarkovProcess development and, since the previous review, adds the BicausalOT formalization, its catalog card, public imports, and NOTICE attribution.

  • BicausalOT includes measurable selection, analytic-set infrastructure, and Bellman results for locally feasible coupling strategies.
  • The BicausalOT solution documentation claims audit and comparator verification whose cited artifacts are absent from the contribution.

Reviews (33) · Last reviewed commit: "Merge current main into Markov process i..."

Comment thread LeanPool/projects.yml Outdated
@Vilin97

Vilin97 commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator Author

🤖 LLM review (gpt-6-astra, 5 rubrics)

Reviewed head: e245cfd2d336f74657d74faacccce7e69ef6657b

Verdict: ✅ approve — computed from the rubric verdicts below, not chosen by a model.

Rubric Verdict Bottom line
Faithfulness ✅ pass The headline theorem proves the card’s claimed existence and uniqueness under its stated semigroup and moment assumptions.
Novelty ✅ pass Direct searches of pinned Mathlib and existing pool sources found no duplicate of MarkovProcess.existsUnique_continuousProcess.
Significance ✅ pass This is a substantial, coherent graduate-level probability project with a clear existence-and-uniqueness theorem and significant supporting theory.
Sources ✅ pass The pinned upstream source states the advertised theorem with matching hypotheses, and the import credits both the upstream development and reused Mathlib definitions.
Code quality (advisory) ✅ pass The development is competently organized around reusable kernel and semigroup interfaces, with no material maintainability issue requiring discussion.
Aspect Value
Proves the claim ✅ proves_it
Assumed, not proved The theorem assumes a nonempty locally compact complete second-countable metric space with its Borel sigma-algebra, a jointly measurable conservative Feller transition semigroup, and a uniform displacement bound ∫ d(z,y)^p P_h(y,dz) ≤ M h^q for all h ≥ 0 and starting states y, with p > 0, q > 1 and finite M ≥ 0. These are the card’s disclosed inputs; continuous-path existence is derived, not assumed. Identity, drift and heat semigroups witness satisfiability.
Matches cited source ✅ matches
Fit ✅ good_fit
Level graduate
Branch probability theory
Mode theory_building
Code quality 3 / 5

Statement check: MarkovProcess.existsUnique_continuousProcess gives exactly one probability kernel into ordinary continuous-path space realizing the iterated transition laws at every finite set of nonnegative real times.

Constructs continuous-path Markov processes from conservative Feller semigroups under Kolmogorov moment bounds, developing strong Markov properties, generator and resolvent theory, stopping and killing, and Brownian motion.


Tokens: 3,459,914 in / 30,963 out across 5 model calls · Tier: codex-subscription · Effort: xhigh · Billing: Codex subscription quota (no API credits) · Estimated cost: $71.5205 (Standard API equivalent; uncached input)
Each rubric is an independent review against .github/review-rubrics/ on top of .github/REVIEW_RULES.md. Disagree? Reply on the PR; rules can be updated in a PR of their own.

@Vilin97

Vilin97 commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator Author

Changes requested by automated review

Reviewed exact current head 2e410f117f1e909a7fc4d71f31b1b81e411c7d69.

The exact-head Build pool/project checks fail in the MarkovProcess import after the module-system migration. In addition, Greptile's current-head P1 finding is material: the card claims an independent comparator audit but the cited Audit/ContinuousMarkovProcess/comparator.json artifact is absent. Port the closure, either add the claimed audit evidence or remove that claim, regenerate the index, and rerun all gates.

Acceptance condition: repair the named defect on a new head and make all required protected checks green. Do not change repository policy or add waivers.

@Vilin97 Vilin97 removed the needs-maintainer Actual human decision required: licensing, mathematical scope, policy, or reviewer disagreement. label Sep 23, 2026
@Vilin97

Vilin97 commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator Author

Changes requested by automated review

Reviewed head 5d36a8f9724eef15d47fe45b579bfa43e55de8b6. Substantial Feller/conservative semigroup construction under the stated moment bounds.

  1. Complete the pinned-toolchain integration. The exact-head build fails. Its concrete error includes:

    error: LeanPool.lean:1:0: cannot import non-`module` LeanPool.MarkovProcess from `module`
    

    The file/dependency audit finds 266 changed Lean files without the required module form. Repair the affected dependency closure, regenerate the module index, and obtain a warning-free full pool build plus the unchanged linter, quality and axiom gates. A project-only or previous-head build does not resolve this failure.

  2. Resolve the substantive source/interface defect. The card asserts a comparator audit at Audit/ContinuousMarkovProcess/comparator.json, but that artifact is not in this import. Link a verifiable upstream audit at the pinned revision or remove the unsupported certification claim; do not present it as pool CI evidence.

Review coverage: complete changed-file inventory and full diff retained; 266 changed project files, 47,671 lines, import reachability and executable trust-token scan; advertised endpoints and supporting definitions examined with bounded implementation sampling and existing review findings reconciled. Potential reusable value: Kernel, filtration and continuous-modification infrastructure. Source/provenance and prior-art evidence were considered separately from CI; these findings do not assert that every proof line was manually read. Earlier automated scores are advisory and are not approval of this failing head.

@Vilin97 Vilin97 added the needs-manual-rebase Maintainer-managed rebase; automatic updater leaves this branch unchanged label Sep 25, 2026

@Vilin97 Vilin97 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{
"reviewed_head": "5c38e7be7af67592b763dcfa0b074a7a1754336e",
"scope": "Resolution of unsupported audit prose only",
"finding_resolved": "The summary no longer claims that the imported theorem was independently checked using the absent Audit/ContinuousMarkovProcess/comparator.json. The mathematical description, hypotheses, source pin, provenance and all Lean files remain unchanged.",
"validation": "Parsed registry comparison proves that removing this one sentence is the sole metadata change. Required-field, value and generated-card checks and git diff --check pass. No compiler or linter settings changed.",
"remaining_work": "This comment does not approve the unfinished module migration or certify an external comparator run. Final-head integration and CI remain with the module-repair owner and maintainer."
}

@Vilin97 Vilin97 added needs-maintainer Actual human decision required: licensing, mathematical scope, policy, or reviewer disagreement. and removed needs-maintainer Actual human decision required: licensing, mathematical scope, policy, or reviewer disagreement. labels Sep 26, 2026
@Vilin97

Vilin97 commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator Author

Reviewed exact head eb69f0b48d4483c6ef8b00355ef2b09a031d22fa. The unchanged endpoint existsUnique_continuousProcess quantifies a unique Markov kernel on continuous paths, with conservativity, Feller and Kolmogorov-moment hypotheses retained.

The complete prior review was carried forward after checking the project source/card and inspecting the repair delta; prior local validation is inherited evidence. Previous rubric review. The original maintainer blocker is resolved; clearing needs-maintainer. Current-base integration and successful required checks remain conditions for a normal protected merge.

Observed checks: Build project: SUCCESS; Content / non-content separation: SUCCESS; Documentation preflight: SUCCESS. Unfinished checks are not passes.

Successor-head reconciliation (eb69f0b48d4483c6ef8b00355ef2b09a031d22fa): The successor only integrates the already independently reviewed main changes; the submitted project source and the cited blocker/repair evidence are unchanged. Current observed gates: Build project=pending, Documentation preflight=SUCCESS, Content / non-content separation=SUCCESS. The disposition remains needs-maintainer. This updates the existing review rather than adding a duplicate comment.

@Vilin97 Vilin97 removed the needs-maintainer Actual human decision required: licensing, mathematical scope, policy, or reviewer disagreement. label Sep 26, 2026
@Vilin97

Vilin97 commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator Author

Disposition: needs-maintainer — protected merge operation.

Reviewed exact head 9aae33d4537947b6a912dad647c1de25f43f66b1. The previous comprehensive source/declaration review was reconciled against this head; valid prior repairs and accurately scoped endpoints are preserved.

The continuous-path Markov kernel is constructed uniquely for conservative Feller semigroups on nonempty locally compact Polish spaces under the explicit Kolmogorov bound.

Protected-check snapshot: Build project: SUCCESS; Content / non-content separation: SUCCESS; Documentation preflight: SUCCESS; GitHub merge state BEHIND. GitHub rejected protected auto-merge with Auto merge is not allowed for this repository. No auto-merge is registered.

Exact maintainer decision: Authorize repository protected auto-merge, or arrange serialized current-main integration and normal protected merging. There is no remaining material mathematical/code blocker supporting requested changes or closure; current protection prevents immediate merge and automation cannot change repository settings under this task. Remove this label before merging.

@Vilin97 Vilin97 added the needs-maintainer Actual human decision required: licensing, mathematical scope, policy, or reviewer disagreement. label Sep 26, 2026
@greptile-apps

greptile-apps Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Comments Outside Diff

These findings sit on lines the diff does not cover, so they could not be posted inline. Each one leaves this list once its file changes.

  • P1 ChipFiring attribution missing from NOTICE LeanPool/projects.yml:10780 ▶

    This registers ChipFiring as an Apache-2.0 project with an upstream repository, but the checked-in NOTICE has no ChipFiring entry. NOTICE says it records the upstream repository and original license for every pooled project, so this import leaves its attribution record incomplete. Regenerate NOTICE from the updated project registry.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

  • P1 Conflicting license declarations LeanPool/projects.yml:10607 ▶

    The new project card lists MIT, but the entry module and constituent Lean files say they are released under Apache 2.0. The entry module also retains an MIT notice for the upstream code without explaining how it relates to the pooled files. Consumers cannot tell which license terms apply to the imported code; please clarify that relationship.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@Vilin97 Vilin97 removed the needs-maintainer Actual human decision required: licensing, mathematical scope, policy, or reviewer disagreement. label Sep 27, 2026

@Vilin97 Vilin97 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-head source-carry review for 5557754c7969d9a0d33e43a9816137edfed3b87d. All 267 MarkovProcess Lean files and the project card are mode/blob-identical to the accepted source 3a601a611fcec66e150c21065d32e659f0ee08ca. The automatic merge preserves all 231 cards and other paths from its integrated main 38da3aaa5b72c2224d7bdff56e60b9005570e534; the root index is the exact sorted union of 8,754 imports. The prior mathematical and helper-sharing reviews therefore carry forward.

The newest Greptile P1 license note is a line attribution error. Its linked old commit 9aae33d4 line 10607 is an unrelated card's MIT field; the MarkovProcess card starts at line 10648 there and says Apache-2.0. The current card says Apache-2.0, all 267 MarkovProcess Lean files have Apache-2.0 headers, and the pinned upstream LICENSE is Apache-2.0. No licensing decision is open from that note.

This source verdict does not clear the operational merge conditions: live main e14988821f16c4419f989ed0e4483d640d1403e5 is newer, and the historical WIP title and “Do not merge” body text need correction at queue turn. Require lossless then-current-main integration and fresh resulting-head full/protected CI before ordinary merge. This is a COMMENT review because GitHub disallows approving one's own PR.

@Vilin97 Vilin97 changed the title WIP: Import markovprocess Import continuous-path Markov process development Sep 28, 2026

@Vilin97 Vilin97 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact integration head 5ceea7e976199e36488df20a64d6e998538f8f54 against the accepted full MarkovProcess source 3a601a611fcec66e150c21065d32e659f0ee08ca and source-identical full-pool-green head ac25e15f87099ecd4b0f233f7c29b3c1f4047213. All 267 project files and the raw project card retain their accepted blobs. Integrating main f4274ced69c745bd18d0ae53bcce3f0c4f0a9072 preserves all 235 pre-existing project cards, every other main path, and the sorted 9,183-import root index.

The prior five-rubric assessment of the continuous-path Markov construction and shared-helper repairs carries forward. The old Greptile MIT attribution is a line in another project's card; this card, every imported header, and the pinned upstream LICENSE identify Apache-2.0. The audit-prose thread is resolved. Content is approved. The resulting-head full-pool and protected checks are pending; merge only after those pass and strict mergeability is CLEAN.

@Vilin97
Vilin97 merged commit 59fcbc0 into main Sep 28, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants