Repository navigation
Import continuous-path Markov process development - #473
Conversation
Proof profile (new / modified Lean files)No proof profile output. |
Automation disposition: needs-maintainerReviewed exact head No concrete author-actionable defect was established in this bounded review that would justify an ordinary change request. The PR is still marked draft, so protected merge is not permitted. Maintainer decision required: confirm the headline result's significance, faithfulness, novelty, source/provenance and scope, then ask the author to mark the PR ready (or give scope direction). This is a maintainer disposition, not an approval. |
|
/review |
|
Advisory cross-file review against Lean Pool's supervisory rubric. This is not by itself a significance, source-verification, or merge verdict. [Low risk] Adds a new mathematical library module for Markov processes. The PR should not merge until the new BicausalOT verification claims are supported or corrected. SummaryThe PR imports the MarkovProcess development and, since the previous review, adds the BicausalOT formalization, its catalog card, public imports, and NOTICE attribution.
Reviews (33) · Last reviewed commit: "Merge current main into Markov process i..." |
🤖 LLM review (
|
| Rubric | Verdict | Bottom line |
|---|---|---|
| Faithfulness | ✅ pass |
The headline theorem proves the card’s claimed existence and uniqueness under its stated semigroup and moment assumptions. |
| Novelty | ✅ pass |
Direct searches of pinned Mathlib and existing pool sources found no duplicate of MarkovProcess.existsUnique_continuousProcess. |
| Significance | ✅ pass |
This is a substantial, coherent graduate-level probability project with a clear existence-and-uniqueness theorem and significant supporting theory. |
| Sources | ✅ pass |
The pinned upstream source states the advertised theorem with matching hypotheses, and the import credits both the upstream development and reused Mathlib definitions. |
| Code quality (advisory) | ✅ pass |
The development is competently organized around reusable kernel and semigroup interfaces, with no material maintainability issue requiring discussion. |
| Aspect | Value |
|---|---|
| Proves the claim | ✅ proves_it |
| Assumed, not proved | The theorem assumes a nonempty locally compact complete second-countable metric space with its Borel sigma-algebra, a jointly measurable conservative Feller transition semigroup, and a uniform displacement bound ∫ d(z,y)^p P_h(y,dz) ≤ M h^q for all h ≥ 0 and starting states y, with p > 0, q > 1 and finite M ≥ 0. These are the card’s disclosed inputs; continuous-path existence is derived, not assumed. Identity, drift and heat semigroups witness satisfiability. |
| Matches cited source | ✅ matches |
| Fit | ✅ good_fit |
| Level | graduate |
| Branch | probability theory |
| Mode | theory_building |
| Code quality | 3 / 5 |
Statement check: MarkovProcess.existsUnique_continuousProcess gives exactly one probability kernel into ordinary continuous-path space realizing the iterated transition laws at every finite set of nonnegative real times.
Constructs continuous-path Markov processes from conservative Feller semigroups under Kolmogorov moment bounds, developing strong Markov properties, generator and resolvent theory, stopping and killing, and Brownian motion.
Tokens: 3,459,914 in / 30,963 out across 5 model calls · Tier: codex-subscription · Effort: xhigh · Billing: Codex subscription quota (no API credits) · Estimated cost: $71.5205 (Standard API equivalent; uncached input)
Each rubric is an independent review against .github/review-rubrics/ on top of .github/REVIEW_RULES.md. Disagree? Reply on the PR; rules can be updated in a PR of their own.
# Conflicts: # LeanPool.lean
Changes requested by automated reviewReviewed exact current head The exact-head Build pool/project checks fail in the MarkovProcess import after the module-system migration. In addition, Greptile's current-head P1 finding is material: the card claims an independent comparator audit but the cited Acceptance condition: repair the named defect on a new head and make all required protected checks green. Do not change repository policy or add waivers. |
Changes requested by automated reviewReviewed head
Review coverage: complete changed-file inventory and full diff retained; 266 changed project files, 47,671 lines, import reachability and executable trust-token scan; advertised endpoints and supporting definitions examined with bounded implementation sampling and existing review findings reconciled. Potential reusable value: Kernel, filtration and continuous-modification infrastructure. Source/provenance and prior-art evidence were considered separately from CI; these findings do not assert that every proof line was manually read. Earlier automated scores are advisory and are not approval of this failing head. |
Vilin97
left a comment
There was a problem hiding this comment.
{
"reviewed_head": "5c38e7be7af67592b763dcfa0b074a7a1754336e",
"scope": "Resolution of unsupported audit prose only",
"finding_resolved": "The summary no longer claims that the imported theorem was independently checked using the absent Audit/ContinuousMarkovProcess/comparator.json. The mathematical description, hypotheses, source pin, provenance and all Lean files remain unchanged.",
"validation": "Parsed registry comparison proves that removing this one sentence is the sole metadata change. Required-field, value and generated-card checks and git diff --check pass. No compiler or linter settings changed.",
"remaining_work": "This comment does not approve the unfinished module migration or certify an external comparator run. Final-head integration and CI remain with the module-repair owner and maintainer."
}
…to codex/import42-markovprocess
# Conflicts: # LeanPool/projects.yml
# Conflicts: # LeanPool/projects.yml
|
Reviewed exact head The complete prior review was carried forward after checking the project source/card and inspecting the repair delta; prior local validation is inherited evidence. Previous rubric review. The original maintainer blocker is resolved; clearing Observed checks: Successor-head reconciliation ( |
|
Disposition: needs-maintainer — protected merge operation. Reviewed exact head The continuous-path Markov kernel is constructed uniquely for conservative Feller semigroups on nonempty locally compact Polish spaces under the explicit Kolmogorov bound. Protected-check snapshot: Build project: SUCCESS; Content / non-content separation: SUCCESS; Documentation preflight: SUCCESS; GitHub merge state Exact maintainer decision: Authorize repository protected auto-merge, or arrange serialized current-main integration and normal protected merging. There is no remaining material mathematical/code blocker supporting requested changes or closure; current protection prevents immediate merge and automation cannot change repository settings under this task. Remove this label before merging. |
# Conflicts: # LeanPool/projects.yml
Comments Outside DiffThese findings sit on lines the diff does not cover, so they could not be posted inline. Each one leaves this list once its file changes.
|
# Conflicts: # LeanPool/projects.yml
# Conflicts: # LeanPool/projects.yml
# Conflicts: # LeanPool/projects.yml
Vilin97
left a comment
There was a problem hiding this comment.
Exact-head source-carry review for 5557754c7969d9a0d33e43a9816137edfed3b87d. All 267 MarkovProcess Lean files and the project card are mode/blob-identical to the accepted source 3a601a611fcec66e150c21065d32e659f0ee08ca. The automatic merge preserves all 231 cards and other paths from its integrated main 38da3aaa5b72c2224d7bdff56e60b9005570e534; the root index is the exact sorted union of 8,754 imports. The prior mathematical and helper-sharing reviews therefore carry forward.
The newest Greptile P1 license note is a line attribution error. Its linked old commit 9aae33d4 line 10607 is an unrelated card's MIT field; the MarkovProcess card starts at line 10648 there and says Apache-2.0. The current card says Apache-2.0, all 267 MarkovProcess Lean files have Apache-2.0 headers, and the pinned upstream LICENSE is Apache-2.0. No licensing decision is open from that note.
This source verdict does not clear the operational merge conditions: live main e14988821f16c4419f989ed0e4483d640d1403e5 is newer, and the historical WIP title and “Do not merge” body text need correction at queue turn. Require lossless then-current-main integration and fresh resulting-head full/protected CI before ordinary merge. This is a COMMENT review because GitHub disallows approving one's own PR.
Vilin97
left a comment
There was a problem hiding this comment.
Reviewed exact integration head 5ceea7e976199e36488df20a64d6e998538f8f54 against the accepted full MarkovProcess source 3a601a611fcec66e150c21065d32e659f0ee08ca and source-identical full-pool-green head ac25e15f87099ecd4b0f233f7c29b3c1f4047213. All 267 project files and the raw project card retain their accepted blobs. Integrating main f4274ced69c745bd18d0ae53bcce3f0c4f0a9072 preserves all 235 pre-existing project cards, every other main path, and the sorted 9,183-import root index.
The prior five-rubric assessment of the continuous-path Markov construction and shared-helper repairs carries forward. The old Greptile MIT attribution is a line in another project's card; this card, every imported header, and the pinned upstream LICENSE identify Apache-2.0. The audit-prose thread is resolved. Content is approved. The resulting-head full-pool and protected checks are pending; merge only after those pass and strict mergeability is CLEAN.
Imports the complete production Lean development from Scott Armstrong's MarkovProcess repository into LeanPool.MarkovProcess, pinned to that source revision and ported to Lean/Mathlib 4.34.0. It retains all 250 upstream production Lean files and their proved solution bridges; the pooled project has 267 Lean files after the module and shared-helper repairs. The project card records Apache-2.0 attribution and AI provenance.
The principal result constructs a unique continuous-path Markov kernel for a conservative Feller transition semigroup under a uniform Kolmogorov displacement-moment bound. Supporting developments cover strong Markov properties, generators and resolvents, stopping and killing, and Brownian motion. The import does not include duplicate open challenge statements, audit harnesses, documentation consumer examples, or the upstream build configuration; their proved production declarations remain in the project.
The 267 project files and raw project card are byte-identical to the accepted source revision
3a601a611fcec66e150c21065d32e659f0ee08ca. The pinned upstream LICENSE, card, and all imported Lean headers identify Apache-2.0. The earlier advisory MIT note cited a line in another project's card.The source-identical head
ac25e15f87099ecd4b0f233f7c29b3c1f4047213passed the hosted full-pool build, challenge build, declaration and text-style linters, repository quality checks, and protected checks. This integration commit5ceea7e976199e36488df20a64d6e998538f8f54preserves all 267 MarkovProcess files, all 235 pre-existing main project cards and other main paths, and the complete sorted index at mainf4274ced69c745bd18d0ae53bcce3f0c4f0a9072. Fresh exact-head CI and strict clean mergeability remain required before merging.