Skip to content

Retain resolved questions across integration follow-ups - #428

Merged
Vilin97 merged 1 commit into
mainfrom
fix/review-resolution-history
Sep 13, 2026
Merged

Vilin97 merged 1 commit into
mainfrom
fix/review-resolution-history

Conversation

@Vilin97

@Vilin97 Vilin97 commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator

Later integration rounds can return only new resolutions. Previously, final enforcement examined only the last round, so #396 incorrectly listed 64 questions answered in earlier rounds as unresolved. Keep an explicit ledger of valid accepted resolutions across calls, expose it to integration, and support explicit reopening when later evidence changes an answer. Unknown IDs never enter the ledger and cannot support approval.

Validation: all 385 Python tests pass; Ruff check/format and diff checks pass. Regressions cover incremental answers, explicit retractions, unknown IDs, and unknown retractions. Replaying saved responses from #385, #393, and #396 preserves the first two verdict tables and removes stale unresolved entries from #396 without any additional model calls; #396 still requires discussion for its remaining substantive concerns.

@greptile-apps

greptile-apps Bot commented Sep 13, 2026

Copy link
Copy Markdown

Advisory cross-file review against Lean Pool's supervisory rubric. This is not by itself a significance, source-verification, or merge verdict.

Retrigger

The PR appears safe to merge; known obligations remain fail-closed while valid earlier resolutions persist across follow-ups.

Summary

  • Maintains a ledger of valid resolutions for known obligations across source follow-ups.
  • Allows earlier resolutions to be explicitly reopened and prevents unknown IDs from entering the accepted ledger.
  • Documents the integration behavior and adds regression coverage for retention, reopening, and unknown IDs.

Reviews (1) · Last reviewed commit: "Keep accepted resolutions across review ..."

@Vilin97
Vilin97 merged commit d64a0ea into main Sep 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant