Repository navigation
Retain resolved questions across integration follow-ups - #428
Merged
Merged
Conversation
|
Advisory cross-file review against Lean Pool's supervisory rubric. This is not by itself a significance, source-verification, or merge verdict. The PR appears safe to merge; known obligations remain fail-closed while valid earlier resolutions persist across follow-ups. Summary
Reviews (1) · Last reviewed commit: "Keep accepted resolutions across review ..." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Later integration rounds can return only new resolutions. Previously, final enforcement examined only the last round, so #396 incorrectly listed 64 questions answered in earlier rounds as unresolved. Keep an explicit ledger of valid accepted resolutions across calls, expose it to integration, and support explicit reopening when later evidence changes an answer. Unknown IDs never enter the ledger and cannot support approval.
Validation: all 385 Python tests pass; Ruff check/format and diff checks pass. Regressions cover incremental answers, explicit retractions, unknown IDs, and unknown retractions. Replaying saved responses from #385, #393, and #396 preserves the first two verdict tables and removes stale unresolved entries from #396 without any additional model calls; #396 still requires discussion for its remaining substantive concerns.