Repository navigation
Retain invalid integration IDs as unresolved findings - #427
Merged
Merged
Conversation
|
Advisory cross-file review against Lean Pool's supervisory rubric. This is not by itself a significance, source-verification, or merge verdict. The PR appears safe to merge, with a non-blocking reliability improvement recommended for atomic evidence checkpoint replacement. Findings
Summary
Reviews (1) · Last reviewed commit: "Retain unknown integration IDs as unreso..." |
| verdict = normalize_rubric_verdict(spec, result.payload) | ||
| print(f"Rubric {spec.key}: {verdict}.", file=sys.stderr) | ||
| outcomes.append(RubricOutcome(spec=spec, result=result, verdict=verdict)) | ||
| _write_review_evidence([outcome.result for outcome in outcomes]) |
There was a problem hiding this comment.
Each completed rubric rewrites the evidence file in place. If a later write is interrupted or fails after truncating the file, the valid earlier checkpoint can become malformed or incomplete, defeating the new recovery guarantee. Write to a temporary sibling and atomically replace the artifact so the last complete checkpoint survives.
Knowledge Base Used:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A large review aborted in its fourth rubric when the integration model cited an unknown obligation ID. Preserve that diagnostic and any unresolved real obligations in a discussion verdict instead of aborting the entire run. Unknown IDs cannot support approval, including an ID that tries to name its own diagnostic.
Also checkpoint each completed rubric so a later failure retains its integrated evidence, coverage, and ordered source reports.
Validation: all 381 Python tests pass; Ruff check/format and diff checks pass. Regressions cover unknown IDs, attempted self-resolution, and retention of a completed rubric after a later failure.