Repository navigation
[codex] Handle empty files in partial port audit - #138
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a ZeroDivisionError in the partial-port audit when an upstream Lean file has zero non-comment LOC by skipping such files during the matched-file truncation ratio computation, and adds a regression test.
Changes:
- Skip zero-LOC upstream files in
evaluate_statstruncation loop. - Add regression test for empty matched upstream files.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/lean_pool/partial_port_audit.py | Guards the truncation-ratio loop against zero-LOC upstream files. |
| python/tests/test_partial_port_audit.py | Adds regression test verifying empty upstream files do not cause divide-by-zero. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Running the audit against
import/hopfieldnetexposed aZeroDivisionErrorwhen an upstream file had zero non-comment LOC. That made the advisory audit crash instead of reporting the actual partial-port signal.Validation
cd python && uv run --group test pytest tests/test_partial_port_audit.pycd python && uv run ruff check lean_pool/partial_port_audit.py tests/test_partial_port_audit.pycd python && uv run python -m lean_pool.partial_port_audit --repo .. --base-ref origin/main --head-ref import/hopfieldnet --json