Rework the algorithm/environment classes and constructors - #254
Open
RemyDegenne wants to merge 9 commits into
Open
RemyDegenne wants to merge 9 commits into
RemyDegenne wants to merge 9 commits into
Conversation
RemyDegenne
marked this pull request as ready for review
October 3, 2026 13:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI disclorure: the new list of names and plan for the organisation of algorithms and environments were done manually. The changes in the code to follow the plan (mostly renames) are done with AI.
See the new naming-convention README at LeanMachineLearning/SequentialLearning/README.md . It gives the current names for algorithms or environments that don't depend on some parts of the problem, as well as proposed names for not yet implemented classes and constructors (marked MISSING).
Environment.banditandEnvironment.banditSeq.Renames:
IsDeterministicAlgAlgorithm.IsDeterministicIsDeterministicEnvEnvironment.HasDeterministicFeedbackIsObliviousEnvEnvironment.IsOblivious(meaning changed, see above)nextAction,actionZeroAlgorithm.nextAction,Algorithm.actionZerofeedbackFun,feedbackFunZeroEnvironment.feedbackFun,Environment.feedbackFunZeroAlgorithm.p0Algorithm.policyZeroEnvironment.obs0Environment.obsZeroEnvironment.ν0Environment.feedbackZerodetAlgorithmAlgorithm.deterministicrandomSamplingAlgorithm.constdetEnvironmentEnvironment.detFeedbackobliviousEnv ν(no observations)Environment.banditSeq νstationaryEnv ν(no observations)Environment.bandit νonlineEvalEnvEnvironment.evalSeq(now built onbanditSeq)evalEnvEnvironment.evalNotable breaking changes: the names
Environment.stationaryandEnvironment.obliviousstill exist, but now mean the versions with observations. Code that used the old observation-free environments should switch toEnvironment.banditandEnvironment.banditSeq.