Avoid module-level requests.Session instances#981
Open
LeMyst wants to merge 1 commit into
Open
Conversation
Remove shared module-level Session objects and use local Session instances per call to avoid shared state and potential side-effects. Replaced helpers_session/default_session with per-call requests.Session() or the provided session argument in mediawiki_api_call, execute_sparql_query, and download_entity_ttl. Keeps behavior the same while preventing reuse of a global session across unrelated requests and reducing risk of stale connections or unintended cookies/headers being shared.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove shared module-level Session objects and use local Session instances per call to avoid shared state and potential side-effects. Replaced helpers_session/default_session with per-call requests.Session() or the provided session argument in mediawiki_api_call, execute_sparql_query, and download_entity_ttl. Keeps behavior the same while preventing reuse of a global session across unrelated requests and reducing risk of stale connections or unintended cookies/headers being shared.