Implementation EntityShape#571
Open
LeMyst wants to merge 1 commit into
Open
Conversation
Owner
Author
|
Github Actions fails because entityshape is not available for Python 3.7. The problem will be solved next week with the depreciation of 3.7 in WBI. |
LeMyst
force-pushed
the
add-entityshape
branch
2 times, most recently
from
43f0bef to
5e76716
Compare
Owner
Author
|
@dpriskorn What's your opinion? |
dpriskorn
reviewed
Jun 25, 2023
dpriskorn
reviewed
Jun 25, 2023
dpriskorn
reviewed
Jun 25, 2023
dpriskorn
reviewed
Jun 25, 2023
dpriskorn
left a comment
dpriskorn
left a comment
Contributor
There was a problem hiding this comment.
Very nice work :)
See my inline comments for suggestions.
dpriskorn
reviewed
Jun 25, 2023
Contributor
|
Also, please note than the support for shex is very basic in entityshape right now. See dpriskorn/entityshape#7 |
Contributor
|
Note: new version with breaking change https://github.com/dpriskorn/entityshape/releases/tag/0.1.0 |
Contributor
|
LGTM |
LeMyst
force-pushed
the
add-entityshape
branch
2 times, most recently
from
c6e23b5 to
aa81f3b
Compare
LeMyst
force-pushed
the
add-entityshape
branch
from
aa81f3b to
9b22100
Compare
Owner
Author
|
@dpriskorn |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #470