Release 0.17.1 — fix multi-monitor placement on glow renderer#12
Merged
Conversation
Cabinet windows (playfield launcher + backglass/DMD covers) opened on the default monitor, un-fullscreen, because `ViewportBuilder::with_monitor` was a no-op on the glow backend: upstream egui only applies the monitor→borderless- fullscreen resolution in the wgpu path, but the glow backend PinReady uses builds its windows straight from `create_winit_window_attributes`. Fixed in the egui fork (pinready-0.35-slim) by extracting the resolution into `apply_monitor_to_window_attributes` and calling it from both glow window- creation sites. PinReady itself is unchanged apart from picking up the fork revision. Validated on the pincab (GNOME 46 Wayland, 3 screens). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0138mtPxwfXPetBypyjp6KwU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ViewportBuilder::with_monitorwas a no-op on the glow backend (whichPinReady uses): upstream egui only applies the monitor→borderless-fullscreen
resolution in the wgpu path. So cabinet windows (playfield + backglass/DMD
covers) opened on the default monitor, un-fullscreen.
Fixed in the egui fork (
pinready-0.35-slim): extract the resolution intoapply_monitor_to_window_attributes, call it from both glow window-creationsites. PinReady is unchanged except for the fork revision + version bump.
Validated on the pincab (GNOME 46 Wayland, 3 screens) — all three windows now
land on the right screen, fullscreen.
🤖 Generated with Claude Code