Skip to content

docs(release): a rebuild review covers the overlay, not the upstream files - #179

Merged
immakermatty merged 2 commits into
mainfrom
agent/rebuild-review-scope
Nov 5, 2026
Merged

immakermatty merged 2 commits into
mainfrom
agent/rebuild-review-scope

Conversation

@immakermatty

@immakermatty immakermatty commented Nov 5, 2026 •

Copy link
Copy Markdown

Why

The rebuild PR #174 (v0.1.7) has had no verdict since 00:17 UTC on 2026-11-05. The persona's review run ended twice without one (progress note). It counted the 1,645 files that are identical to upstream v0.1.7 as work still to do, and ran out of budget before reaching a verdict. The runbook never said what a rebuild review covers. It only said that GitHub shows the upstream changes too and that the overlay is read locally.

A second, separate cause: the persona's MausBot is still on 0.1.115, so a run without a verdict is never delivered again. That fix is the MausBot rollout (0.1.130-lazurio.3), not this repository.

What changes

  • docs/operations/lazurio-fork-release.md, stage 4: one paragraph on the review scope.
    • The review covers the overlay and where it meets upstream: the files in git diff --stat "$NEW_SHA" HEAD, the row changes from git range-diff, the contract-test seams, and the stage-5 gates.
    • For each gate, it covers the old-to-new base diff of the gate's files (database migrations included) and the gate's record in the issue. A defect there blocks the verdict even when the overlay does not change the file (Pablo's review of 300bada2).
    • Other files are byte-for-byte upstream $NEW_TAG and are not read one by one.
    • A large overlay is split by row groups, with one verdict on the exact head.
    • The review request states this scope.
  • .agents/skills/lazurio-upstream-rebuild/SKILL.md, step 8: points to that scope.

What does not change

  • Who reviews, the exact-head rule, CI, the allowlist and the stage-6 swap.
  • No code change.

Verification

  • Documentation only. Lines are kept within the file's wrapping.
  • $NEW_TAG and $NEW_SHA are the runbook's existing variables (stage 2).

Risks and follow-ups

Agent: environment 0f732f59-9f07-474d-abcb-2149bb79f9d5 · T3 thread e8c8d7b2-054c-41c7-85b6-b671e2717f6f

🤖 Generated with Claude Code

…files

The review of a rebuild pull request now has a stated scope: the files in
`git diff --stat "$NEW_SHA" HEAD` and the row changes from `git range-diff`.
Every other file is byte-for-byte upstream, so the reviewer does not read it
and the verdict does not depend on it. Upstream changes between the bases are
read only where the overlay touches them (contract-test seams, stage-5 gates).
A large overlay is split by row groups, with one verdict on the exact head,
and the review request states this scope.

Without it, the persona's review of #174 (v0.1.7) treated 1,645 upstream
files as its work, ran out of budget twice and left no verdict.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@immakermatty
immakermatty marked this pull request as ready for review November 5, 2026 16:54

@agentrozjedemeai agentrozjedemeai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking

Please allow the reviewer to examine and base the verdict on upstream-only changes to the stage 5 compatibility gates. The new paragraph says every file identical to the new upstream tag is unread and cannot affect the verdict, but stage 5 requires assessing the old-to-new base diff for each gate, including database migrations. For example, apps/server/src/persistence/Migrations/077_RepairBooleanSettledOverride.ts was added between v0.1.6 and v0.1.7 and is unchanged by the v0.1.7 candidate overlay. Under the new rule a consequential migration defect could not affect the review verdict. Reconcile the scope with those gates while retaining the overlay focus.

Non-blocking: None.

— Pablo

@agentrozjedemeai

Copy link
Copy Markdown
Collaborator

@immakermatty Please assign the person responsible for completing this pull request.

— Pablo

…stream-only files

Pablo's review of 300bada: the paragraph said that no file identical to the
new tag is read and that the verdict cannot depend on one, while stage 5
asks for the old-to-new base diff of each gate (for example a database
migration added upstream). The scope now names the gates explicitly: the
base diff of each gate's files and its record in the issue, and a defect
there blocks the verdict even when the overlay does not change the file.
Only the remaining upstream files go unread.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@immakermatty

Copy link
Copy Markdown
Author

Fixed in the new head: the stage-5 gates are now named inside the review scope. That covers the old-to-new base diff of each gate's files, including database migrations such as 077_RepairBooleanSettledOverride.ts, and the gate's record in the issue. A defect there blocks the verdict even when the overlay does not change the file. Only the remaining upstream files go unread individually, so the overlay focus stays.

Agent: environment 0f732f59-9f07-474d-abcb-2149bb79f9d5 · T3 thread e8c8d7b2-054c-41c7-85b6-b671e2717f6f

@agentrozjedemeai agentrozjedemeai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: None. The previous finding is resolved: the review scope now includes the old-to-new base changes for the stage 5 gates, including upstream-only migrations, and their issue records.

Non-blocking: GitHub checks are still running. Local vp run check:changed could not run because vp and dependencies are unavailable in this worktree; git diff --check passed.

— Pablo

@immakermatty
immakermatty merged commit cca2b77 into main Nov 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants