Repository navigation
lazurio: backport upstream's fixed clock for the free/busy test of Marco's assistant (DEV-6691) - #81
Merged
Conversation
…'s assistant (DEV-6691) Upstream v0.1.130's server/host/team-messages.test.ts gives Marco's assistant a busy slot on 2026-10-29 14:00-15:00 UTC and lets it read the real clock, so since that slot passed the test fails on every run, and with it the Linux vitest shard of main and of every pull request. Upstream fixed the test after v0.1.130 (milind-soni/OpenMausBot d915c2d); the next commit backports it unchanged, with its author. This commit lists the test file in allowed_upstream_changes and adds the backport's row to the overlay table. Both drop at the next upstream refresh, whose tag contains the fix. The server does not change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ursday slot is still ahead (milind-soni#3850) The busy slot is Thursday 29 Oct 14:00-15:00 UTC, but the assistant read the real clock. From 15:00 UTC on Oct 29 the slot was in the past, the facts said 'Busy times in the next 14 days: none', and the test failed on every run. That made every PR's and main's Linux shard 4 red. It now gets the same fixed clock as representative.test.ts, two days before the slot. (cherry picked from commit d915c2d) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
agentrozjedemeai
approved these changes
Oct 31, 2026
agentrozjedemeai
left a comment
Collaborator
There was a problem hiding this comment.
Blocking: None.
Non-blocking: The four full Vitest shards were still running at review time. The focused test passed 18/18 and the release, CI scope, removals and browser contract tests passed 558/558 locally; the overlay/typecheck/lint and archive CI jobs passed.
— Pablo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Since 2026-10-29 15:00 UTC the Linux job
vitest (shard 4/4)fails onmainand on every pull request of this fork, for a reason none of them caused.server/host/team-messages.test.ts› "Marco's assistant › answers a free/busy question itself, says so where it was asked and in his inbox, and notifies him once".expect(prompt).toContain("Thu 29 Oct 14:00–15:00")fails on every run.mainat077c8b04d(run 41145354786) failed this way, and so does lazurio: WhatsApp intake, model-free WhatsApp group triggers for a support bot (DEV-6691) #80's shard 4.d915c2d8a. The assistant gets the same fixed clock asrepresentative.test.ts, two days before the slot. No upstream tag contains it yet.What changes
Two commits on
main(077c8b04d):lazurio: allow upstream's fixed clock for the free/busy test of Marco's assistant (DEV-6691).server/host/team-messages.test.tsinallowed_upstream_changesoflazurio-fork-ci.yml, with the reason.docs/operations/lazurio-fork-release.md, as the release contract requires.test(team-messages): Marco's assistant reads a fixed clock, so his Thursday slot is still ahead (#3850).d915c2d8a, cherry-picked with-x. The author stays Milind Soni and the message is upstream's; only the(cherry picked from …)line sits before upstream's own trailer.main's.Order. The allowlist line lands first, so every commit passes the overlay guard.
Placement, so #80 does not conflict. #80 adds its own row at the end of the overlay table and its own allowlist comment further down. This pull request touches neither place:
release:row;The two pull requests therefore merge in either order without a conflict.
What does not change
nowoption already exists in v0.1.130 (server/host/representative.ts), so the test needs nothing else.pull_request.head.sha), not a merge withmain, so lazurio: WhatsApp intake, model-free WhatsApp group triggers for a support bot (DEV-6691) #80 turns green once it is rebased onto amainthat contains this.Verification
On head
5ff51f856, with a clean tree:pnpm exec vitest run --config lazurio/vitest.config.mjs server/host/team-messages.test.ts:main's copy of the file, on today's clock (2026-10-31), 1 of 18 fails: the same test as in CI.node --test scripts/lazurio-release-contract.node-test.mjs scripts/lazurio-ci-scope.node-test.mjs scripts/lazurio-removals.node-test.mjs scripts/lazurio-browser-contract.node-test.mjs: 558 pass, 0 fail.UPSTREAM_SHA.main's workflow file, it names exactlyserver/host/team-messages.test.ts.pnpm lint,pnpm typecheckandpnpm i18n:checkpassed at the push.d915c2d8a's.Follow-ups
d915c2d8a: drop both commits, the allowlist line and the row. The row says so.main; its shard 4 then runs the fixed test.Work context
b1c9ff48-4099-41df-9eeb-60d084045c73, local to the machine..worktrees/productionspace/OpenMausBot/DEV-6691-backport-free-busy-clock, branchagent/DEV-6691-backport-free-busy-clock, frommainat077c8b04d.🤖 Generated with Claude Code
Note
Backport upstream fixed clock for Marco's assistant free/busy test
Adds a fixed timestamp of October 27, 2026 at 09:00 UTC to the representative's
nowcallback in the Marco's assistant test fixture in team-messages.test.ts. This backports an upstream fix for a date-dependent free/busy test failure.Macroscope summarized 5ff51f8.