Skip to content

lazurio: backport upstream's fixed clock for the free/busy test of Marco's assistant (DEV-6691) - #81

Merged
immakermatty merged 2 commits into
mainfrom
agent/DEV-6691-backport-free-busy-clock
Oct 31, 2026
Merged

immakermatty merged 2 commits into
mainfrom
agent/DEV-6691-backport-free-busy-clock

Conversation

@immakermatty

@immakermatty immakermatty commented Oct 31, 2026 •

Copy link
Copy Markdown

Why

Since 2026-10-29 15:00 UTC the Linux job vitest (shard 4/4) fails on main and on every pull request of this fork, for a reason none of them caused.

What changes

Two commits on main (077c8b04d):

  1. lazurio: allow upstream's fixed clock for the free/busy test of Marco's assistant (DEV-6691).
    • It lists server/host/team-messages.test.ts in allowed_upstream_changes of lazurio-fork-ci.yml, with the reason.
    • It adds the backport's row to the overlay table in docs/operations/lazurio-fork-release.md, as the release contract requires.
    • The row and the allowlist comment both say the backport is dropped at the next upstream refresh, whose tag contains it, together with the allowlist line.
  2. test(team-messages): Marco's assistant reads a fixed clock, so his Thursday slot is still ahead (#3850).
    • This is upstream's d915c2d8a, cherry-picked with -x. The author stays Milind Soni and the message is upstream's; only the (cherry picked from …) line sits before upstream's own trailer.
    • It adds 3 lines and removes 1: the same changed lines as upstream's commit. Only the hunk's line numbers differ, because v0.1.130's copy of the file is older than upstream main's.

Order. The allowlist line lands first, so every commit passes the overlay guard.

Placement, so #80 does not conflict. #80 adds its own row at the end of the overlay table and its own allowlist comment further down. This pull request touches neither place:

  • the row sits right after the release: row;
  • the allowlist line sits with the overlay's other two upstream test fixes.

The two pull requests therefore merge in either order without a conflict.

What does not change

Verification

On head 5ff51f856, with a clean tree:

  • The test file. pnpm exec vitest run --config lazurio/vitest.config.mjs server/host/team-messages.test.ts:
    • with the backport, 18 of 18 pass;
    • with main's copy of the file, on today's clock (2026-10-31), 1 of 18 fails: the same test as in CI.
  • Contract tests. node --test scripts/lazurio-release-contract.node-test.mjs scripts/lazurio-ci-scope.node-test.mjs scripts/lazurio-removals.node-test.mjs scripts/lazurio-browser-contract.node-test.mjs: 558 pass, 0 fail.
  • The overlay guard. I replayed the CI step "overlay may change only listed upstream files" locally, with the workflow's own list and UPSTREAM_SHA.
    • With this head, it passes.
    • With main's workflow file, it names exactly server/host/team-messages.test.ts.
  • Pre-push hook. pnpm lint, pnpm typecheck and pnpm i18n:check passed at the push.
  • Same change as upstream. The added and removed lines of the cherry-pick are byte-identical to d915c2d8a's.
  • Not run locally. The other three vitest shards; CI runs them.

Follow-ups

Work context

  • Agent / thread: Claude Code (Opus 5.5), an implementation subagent of the DEV-6691 parent thread in T3 Code; session b1c9ff48-4099-41df-9eeb-60d084045c73, local to the machine.
  • Machine: the Organization Admin's macOS workstation.
  • Worktree: the HumanAndMachine-ai Organization root, .worktrees/productionspace/OpenMausBot/DEV-6691-backport-free-busy-clock, branch agent/DEV-6691-backport-free-busy-clock, from main at 077c8b04d.
  • Mission Control: plan DEV-6691, in the Organization's private Mission Control data.

🤖 Generated with Claude Code

Note

Backport upstream fixed clock for Marco's assistant free/busy test

Adds a fixed timestamp of October 27, 2026 at 09:00 UTC to the representative's now callback in the Marco's assistant test fixture in team-messages.test.ts. This backports an upstream fix for a date-dependent free/busy test failure.

  • Adds the test file to the overlay job's allowed upstream changes in lazurio-fork-ci.yml, with a note on when the exception can be removed
  • Documents the backport in the overlay commit table in lazurio-fork-release.md; the change is test-only and will be removed at the next upstream refresh

Macroscope summarized 5ff51f8.

immakermatty and others added 2 commits October 31, 2026 11:44
…'s assistant (DEV-6691)

Upstream v0.1.130's server/host/team-messages.test.ts gives Marco's
assistant a busy slot on 2026-10-29 14:00-15:00 UTC and lets it read the
real clock, so since that slot passed the test fails on every run, and
with it the Linux vitest shard of main and of every pull request.
Upstream fixed the test after v0.1.130 (milind-soni/OpenMausBot
d915c2d); the next commit backports it unchanged, with its author.

This commit lists the test file in allowed_upstream_changes and adds the
backport's row to the overlay table. Both drop at the next upstream
refresh, whose tag contains the fix. The server does not change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ursday slot is still ahead (milind-soni#3850)

The busy slot is Thursday 29 Oct 14:00-15:00 UTC, but the assistant read the
real clock. From 15:00 UTC on Oct 29 the slot was in the past, the facts said
'Busy times in the next 14 days: none', and the test failed on every run.
That made every PR's and main's Linux shard 4 red. It now gets the same fixed
clock as representative.test.ts, two days before the slot.

(cherry picked from commit d915c2d)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

@agentrozjedemeai agentrozjedemeai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: None.

Non-blocking: The four full Vitest shards were still running at review time. The focused test passed 18/18 and the release, CI scope, removals and browser contract tests passed 558/558 locally; the overlay/typecheck/lint and archive CI jobs passed.

— Pablo

@immakermatty
immakermatty merged commit cdbe949 into main Oct 31, 2026
7 checks passed
@immakermatty
immakermatty deleted the agent/DEV-6691-backport-free-busy-clock branch October 31, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants