feat: add -compile flag to compile definitions#20
Merged
Conversation
88c9e22 to
12b4636
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When releasing the mod people probably want their definitions all compiled and packaged with the release
However if you don't already have these ".compiled" files then the game only lazy-compile them when EnsureDefinitionsLoaded is manually called somewhere.
This is not convenient when say you add your own definitions..
With this change, after building the exe, people can run it with
-compilecommand to ensure all definitions are compiled, then they can pack that into the pak with the release. When running with-compile, the game will just compile the things and exit, so it can be run in automation (it still tries to show the window, since that's hardcoded in SexyAppBase and I didn't want to touch that in case I break something)With this also supports loading compiled definitions from pak
Also made some small modernization changes