allow stone button to be draw correctly with any size#18
Merged
Conversation
Pistonight
force-pushed
the
fix/stonebutton
branch
from
d47ae40 to
386f644
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The currently implementation only draws the button to be the same size as the hitbox for specific sizes, which might be intended (?) if originally the button is only meant to be certain sizes. But this is a pain for making custom UI since almost always the button will be too short and the text looks not-centered
with this fix the stone button will always draw to the same size as the hitbox. truncating the texture is barely noticeable