docs: starter-repo follow-ups are done - #8
Conversation
check_project.py already accepts the bundle-hint block (verified against a generateMenuConfig() file, and it still rejects stray code), and the starter's committed menu_config.py carries the hints, so ModuleFinder now reaches both sample missions. robot_setup_template.py exists now; what remains is each team's own robot_setup.py. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Lansing-Tech-Studio/pybricks-git-extension/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthrough
ChangesStarter-repo compatibility documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to This documentation update records verified compatibility behavior and the remaining setup prerequisite without changing runtime code. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
CLAUDE.mdstill listed two starter-repo changes as "required, not yet done". Both are already in../pybricks-spike-prime-starter(main). I checked them before changing the docs; this PR is docs only.check_project.pyaccepts the bundle-hint preamble (_strip_bundle_hints). It passes on amenu_config.pywritten by this repo's owngenerateMenuConfig(), including a whole-program slot and anenabled: Falseslot. It still reports a PROBLEM for a non-import inside theif _BUNDLE_HINTS:block, and for any stray top-level statement.menu_config.pycarries the hint block.ModuleFinderover the starter'smain.pynow reachesmission_01_go_out_and_turnandmission_02_come_back_home;CLAUDE.mdrecorded that it used to find neither. Over a generated config it also reachesmath_demoandmission_template.The "Starter-repo follow-ups" section becomes a short "Starter-repo compatibility" record, with a reminder to re-run the starter's checker if the generator's output shape changes again.
The production prerequisite paragraph is updated too.
robot_setup_template.pyis now authored and committed in the starter (ad88b2c). What remains is per-team: each fork needs its ownrobot_setup.py, made from the template in the editor. The starter deliberately has none, andcheck_project.pyreports that as INFO.🤖 Generated with Claude Code
Summary by CodeRabbit