Skip to content

fix: preserve cached usage when deleting accounts #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bl0ck154 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: preserve cached usage when deleting accounts #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/hooks/useAccounts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,19 @@ export function useAccounts() {
const deleteAccount = useCallback(
async (accountId: string) => {
try {
const deletedAccount = accountsRef.current.find((account) => account.id === accountId);
await invokeBackend("delete_account", { accountId });
await loadAccounts();

if (deletedAccount && !deletedAccount.is_active) {
// Deleting an inactive account does not change any other account. Keep
// their already-fetched usage in place instead of rebuilding the list.
setAccounts((prev) => prev.filter((account) => account.id !== accountId));
return;
}

// Removing the active account can make another account active on the
// backend. Re-read account metadata, but never discard cached usage.
await loadAccounts(true);
} catch (err) {
throw err;
}
Expand Down