Repository navigation
Conversation
…en rounds The no-argument setToUnfiltered() keeps the current size, which is what the next intersect round needs, but the call did not say so. Pass the size and note that twoWayIntersect leaves the surviving left IDs at the front of the key vector. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work was produced with the help of language models.
Follow-up to the review of #1372 (#1372 (comment)). Between intersect rounds,
Intersect::intersectListsreset its left selection vector with the no-argumentsetToUnfiltered(), which keeps the current size. That size is what the next round needs, but the call did not say so.Change. It now passes the size,
leftSelVector.setToUnfiltered(leftSelVector.getSelSize()), with a comment thattwoWayIntersectleaves the surviving left IDs at the front ofoutKeyVector. Behaviour is unchanged.Tests. No new test: resetting the size to the first list's length instead fails
acc_hj,cyclic/single_label,cyclic/multi_labelandcyclic/large_lists. Full ctest: 3184/3184.