Repository navigation
Conversation
Persistent CSR length chunks are ResidencyState::ON_DISK, so reading them via ColumnChunk::getValue returns uninitialized memory (garbage degrees / 0). Scan the length through its Column like forEachDegree/CountRelTable instead, under captureScanPin so parked readers get their retained snapshot. Also count uncommitted local rels even when the node group has no committed CSR group. Fixes LadybugDB#1292
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1292.
Root cause:
RelTable::getDegreeForOffsetread the persistent CSR length directly from theChunkedCSRNodeGroup'sColumnChunk(ChunkedCSRHeader::getCSRLength→ColumnChunk::getValue). Those header chunks areResidencyState::ON_DISK, so their in-memory buffers are zero-size/not positionally valid — in release builds this reads out-of-bounds/uninitialized memory, producing garbage degrees (~1e14) or 0 for valid offsets. It also bypassed the scan-pin/retained-snapshot routing.Fix:
captureScanPin(transaction)and scan the single length value through itsColumn(same pattern asforEachDegree/CountRelTable).pin.index.forEachDegree's local-only-group handling).Tests: extended
RelDegreeTest.MatchesCypherAcrossNodeGroupsAndStorageStatesto assertgetDegreeForOffset == degreefor every expected entry across checkpointed, committed in-memory, and uncommitted states.