Repository navigation
fix(ci): pin macOS Node.js build to OpenSSL 3 - #1281
Merged
Merged
Conversation
Same failure as the precompiled-bin and Java macOS jobs: the macos-26 runner image now provides Homebrew openssl@4 alongside openssl@3, and CMake's find_package(OpenSSL 3) (>= 3) resolves to 4.x, tripping the OpenSSL 3.x version guard in CMakeLists.txt: Ladybug requires OpenSSL 3.x but found 4.0.3. Fixes https://github.com/LadybugDB/ladybug/actions/runs/38963529396/job/117214998838. Add the same Install OpenSSL 3 (macOS) step (brew install openssl@3 when missing, export OPENSSL_ROOT_DIR) ahead of the CMake configure in nodejs-workflow.yml and python-wheel-workflow.yml, whose macOS cibuildwheel/CMake builds hit the identical error.
The Python wheel build runs inside a cibuildwheel builder with its own OpenSSL, so the Homebrew openssl@3 pin is unnecessary there. Keeps the nodejs-workflow.yml pin, which is the reported failure.
adsharma
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same failure class as #1277 and the Java pin: the macos-26 runner image provides Homebrew openssl@4 alongside openssl@3, and CMake's
find_package(OpenSSL 3)resolves to 4.x, tripping the OpenSSL 3.x guard inCMakeLists.txt:Fixes https://github.com/LadybugDB/ladybug/actions/runs/38963529396/job/117214998838 (build-nodejs macOS job; that run is on branch
sync_submodule2, which will pick this up on rebase).Adds the same
Install OpenSSL 3 (macOS)step (brew install openssl@3when missing, exportOPENSSL_ROOT_DIR) ahead of the CMake configure in:nodejs-workflow.yml(the reported failure —make GEN=Ninja nodejson macOS)python-wheel-workflow.yml(identical latent failure — macOScibuildwheelruns the same CMake configure)Follows the pattern from #1277 / the Java pin. The
OPENSSL_ROOT_DIRmechanism was already verified end to end (forces 3.6.4 even with openssl@4 first on the search path).