Skip to content

Shim prepared-statement schema via public getArrowSchema() #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adsharma merged 1 commit into from
Sep 15, 2026
Merged

Shim prepared-statement schema via public getArrowSchema() #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/lbug_arrow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
#include <stdexcept>
#include <vector>

#include "common/arrow/arrow_converter.h"

namespace lbug {
namespace main {

Expand Down Expand Up @@ -72,9 +70,8 @@ ArrowSchema query_result_get_arrow_schema(const lbug::main::QueryResult& result)
}

ArrowSchema prepared_statement_get_arrow_schema(const lbug::main::PreparedStatement& stmt) {
// Schema only: names/types come from the bound and planned statement, no execution.
return *lbug::common::ArrowConverter::toArrowSchema(stmt.getColumnTypes(),
stmt.getColumnNames(), false /* fallbackExtensionTypes */);
// Schema only, implemented in core: no execution, no internal headers needed here.
return *stmt.getArrowSchema();
}

bool query_result_has_next_arrow_chunk(lbug::main::QueryResult& result) {
Expand Down
Loading