Repository navigation
Make un-awaited getAll() fail loudly instead of yielding {} - #27
Merged
Merged
Conversation
QueryResult.getAll() is async; calling it without await returns a
pending Promise that JSON.stringify renders as '{}', which looks like
an empty result and can make tests falsely pass.
getAll() now returns a Promise subclass whose toJSON() throws a
descriptive error (use await getAll() or getAllSync()), turning the
silent footgun into a loud failure. Awaited behavior is unchanged.
JSDoc and lbug.d.ts now warn prominently on all async accessors.
Contributor
Author
|
Ignoring windows failure for now. It should go away when we build new extensions from main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26.
QueryResult.getAll() is async; calling it without await returns a pending Promise that JSON.stringify renders as '{}', which looks like an empty result and can make tests falsely pass.
getAll() now returns a Promise subclass whose toJSON() throws a descriptive error (use await getAll() or getAllSync()), turning the silent footgun into a loud failure. Awaited behavior is unchanged. JSDoc and lbug.d.ts now warn prominently on all async accessors, and regression tests cover the issue's querySync repro.