Repository navigation
fix(sqlite): use std::memcpy for MSVC compat in btree decoder - #128
Merged
Merged
Conversation
__builtin_memcpy is GCC/Clang-only and breaks the Windows (MSVC) build with C3861. std::memcpy is portable (<cstring> already included). Fixes Windows build failure in LadybugDB/ladybug run 38760029672.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows (MSVC) build fails with:
btree_page_decoder.cpp(61): error C3861: '__builtin_memcpy': identifier not foundhttps://github.com/LadybugDB/ladybug/actions/runs/38760029672/job/116508543768
__builtin_memcpy is GCC/Clang-only. std::memcpy is portable ( already included).
One-line change in sqlite/src/cdc/btree_page_decoder.cpp. Ladybug main repo will need an extension submodule bump after merge.