Repository navigation
Name projected-graph parameter in GDS signatures - #127
Merged
Merged
Conversation
All GDS table functions take a projected-graph name yet registered a
bare ANY parameter, so arity mismatches reported the unhelpful
'Expected: (ANY)'. Register STRING with parameterNames {"graph_name"}
(plus LIST "sources" for the PPR extra arg) so failures read
'Expected: (graph_name STRING)'.
Pairs with LadybugDB/ladybug#1265, which adds parameterNames support
and a CALL PROJECT_GRAPH(...) hint to the core function-match error.
Renders as (graph_name STRING,sources INT64[]) in signatures and function-match errors.
adsharma
added this pull request to stack #131
October 16, 2026 15:52
CALLs with a LIST-typed extra (GDS_PPR sources) fail to bind: the binder builds input LogicalTypes from the declared LogicalTypeIDs and a bare LIST ID carries no child info. Set inferInputTypes when the descriptor takes extra args so the nested type comes from the CALL-site argument instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to LadybugDB/ladybug#1265 for LadybugDB/ladybug#1223.
All GDS table functions take a projected-graph name yet registered a bare ANY parameter, so e.g. CALL page_rank('v','e') reported the unhelpful Expected: (ANY). This registers STRING with parameterNames {"graph_name"} (plus LIST "sources" for the PPR extra arg), so failures read Expected: (graph_name STRING) with a CALL PROJECT_GRAPH(...) hint from core.