Repository navigation
Conversation
The phantom-document case in copy_ignore_errors.test pinned the BM25 score 0.353634, which would change with any scoring or data change. It now checks that the table holds the three surviving rows, builds a second index after the COPY and checks that both indexes score the document the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work was produced with the help of language models.
Follow-up to #123. Its phantom-document case in
copy_ignore_errors.testpinned the BM25 score0.353634; @adsharma noted in review that an exact score match is brittle and would need updating with every scoring or data change.The case now builds one FTS index before
COPY ... (ignore_errors=true), which is maintained through it and would pick up the phantom document, and a second one after it, which cannot, and checks that both score the surviving document the same. No score value is pinned. Without the #123 fix the case fails with2|False. Test-only change.