Repository navigation
fix(fts): keep the case of ignore_pattern - #116
Merged
Merged
Conversation
CREATE_FTS_INDEX lowercased ignore_pattern before compiling it, but the pattern is matched against the text before the text is lowercased, so capitals in the pattern changed meaning: [^A-Za-z]+ stripped capital letters, and \W+ became \w+, which strips every word. The pattern is now used as written. Indexes created earlier keep their stored pattern and tokenize as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work was produced with the help of language models.
Fixes #115.
CREATE_FTS_INDEXlowercasedignore_patternbefore compiling it, while the pattern is applied to the text before the text itself is lowercased. Capitals in the pattern therefore changed its meaning:[^A-Za-z]+became[^a-za-z]+and stripped every capital letter, so'Ladybug Graph'was indexed asadybugandraph, and\W+became\w+, which strips every word and leaves nothing to index.Fix. The pattern is used as written;
IgnorePattern::validatestill compiles it at bind time, and the query-side pattern is the same string. Indexes created earlier keep their stored, lowercased pattern in both the index entry and the tokenize macro, so they tokenize exactly as before.Tests.
ignore_pattern.testgains a case that indexes'Ladybug Graph'and'Quiet Morning'under[^A-Za-z]+and under\W+, checks thatladybug,Morning,graphandquietare found andadybugis not, and repeats a query after-RELOADDBto cover the stored pattern. It fails on main and passes here. FTS extension tests: no new failures.