Fix for testUpdateAndDeleteWithCommentsAndFlags#3004
Open
DariaBod wants to merge 2 commits into
Open
Conversation
labkey-tchad
approved these changes
May 18, 2026
Member
labkey-tchad
left a comment
labkey-tchad
left a comment
There was a problem hiding this comment.
Consider using TestDataUtils
Comment on lines
969
to
979
| List<String> fileData = new ArrayList<>(); | ||
| fileData.add(String.format("%s\t%s", "Name", field01.getLabel())); | ||
| fileData.add(CSVFormat.TDF.format("Name", field01.getLabel())); | ||
| for(Map<String, String> sample : sampleData) | ||
| { | ||
| fileData.add(String.format("%s\t%s", sample.get("Name"), sample.get(field01.getName()))); | ||
| fileData.add(CSVFormat.TDF.format(sample.get("Name"), sample.get(field01.getName()))); | ||
| } | ||
|
|
||
| String fileName = "SampleTypeTest_UpdateSamples.tsv"; | ||
| if (!TestFileUtils.getTestTempDir().exists()) | ||
| TestFileUtils.getTestTempDir().mkdirs(); | ||
| File importFile = TestFileUtils.writeTempFile(fileName, String.join(System.lineSeparator(), fileData)); |
Member
There was a problem hiding this comment.
We should use the dedicated helper methods from TestDataUtils instead of having individual tests deal with file formatting.
List<Map<String, Object>> fileData = new ArrayList<>();
for(Map<String, String> sample : sampleData)
{
fileData.add(Map.of(sample.get("Name"), sample.get(field01.getName())));
}
String fileName = "SampleTypeTest_UpdateSamples.tsv";
File importFile = TestDataUtils.writeDataToFile(fileName, fileData);
labkey-danield
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Test failed because of wrong
"processing. Also was filed issue because of silent operation fails in the app.Related Pull Requests
Changes