Skip to content

[bot] Merge 26.5 to develop (Conflicts)#636

Merged
github-actions[bot] merged 3 commits into
developfrom
fb_bot_merge_26.5
May 20, 2026
Merged

[bot] Merge 26.5 to develop (Conflicts)#636
github-actions[bot] merged 3 commits into
developfrom
fb_bot_merge_26.5

Conversation

@github-actions
Copy link
Copy Markdown

Automatic merge failed! Please merge 26.5 into fb_bot_merge_26.5 and resolve conflicts manually.

git fetch
git checkout fb_bot_merge_26.5
git reset --hard origin/develop
git merge 601d2dd43358a63284adf53adb931d92329856dd -m "Merge 26.5 to develop"

Resolve all conflicts (using IntelliJ or git mergetool)

git commit
git push --force

Approve all matching PRs simultaneously.
Approval will trigger automatic merge.
Verify all PRs before approving: https://internal.labkey.com/Scrumtime/Backlog/harvest-gitOpenPullRequests.view?branch=fb_bot_merge_26.5

vagisha and others added 2 commits May 14, 2026 22:52
…tion, and Selenium tests (#622)

- `TestResultsSchema `extends UserSchema with DefaultSchema.registerProvider() registration, FK lookup columns, and wrapAllColumns() in createTable()
  - _Post-deploy_: Delete external schema on skyline.ms since the code-level registration now supersedes it. 
- Added form classes replacing all request.getParameter() calls across all actions
- Integer/Boolean for optional form parameters with null guards and descriptive error messages
- ParseException handling with SimpleErrorView for date parameters
- `cause` field added to error API responses; JSP alert messages updated to display it
- Added addNavTrail overrides to prevent missing page title warnings
- New `TestResultsTest` Selenium test class covering begin page, show run, run lookup, user runs, long-term trends, failures, flagging, and training data workflows
  - `BeginAction` (rundown page, date navigation, viewType selector)
  - `ShowRunAction` (run detail, pass sorting)
  - `ShowUserAction` (user page, date range)
  - `LongTermAction` (viewType selector)
  - `ShowFailuresAction` (failure detail, viewType selector)
  - `FlagRunAction` / `ShowFlaggedAction` (flag/unflag workflow)
  - `TrainRunAction` / `TrainingDataViewAction` (add/remove training set workflow)
  - `ViewLogAction` (view run log)
  - `ViewXMLAction` (view run XML)
  - `ChangeBoundariesAction` (update warning/error boundaries)
  - `SetUserActiveAction` (activate/deactivate user)
  - `DeleteRunAction` (delete a run)
- Replaced deprecated `javax.management.modelmbean.XMLParseException` with `IllegalArgumentException`
- Switched from `org.springframework.util.StringUtils` to `org.apache.commons.lang3.StringUtils`
@github-actions github-actions Bot merged commit 9de34b1 into develop May 20, 2026
6 of 8 checks passed
@github-actions github-actions Bot deleted the fb_bot_merge_26.5 branch May 20, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants