Repository navigation
Conversation
fjaviersanchez
left a comment
fjaviersanchez
left a comment
There was a problem hiding this comment.
I think that it would be good to rename the add methods in GeomUnion and GeomIntersection to append, but this is just an opinion and shouldn't prevent the PR from merging. The defragmentation feature is very cool. Thanks a lot!
| return np.stack([out_starts, out_ends], axis=1) | ||
|
|
||
|
|
||
| hpg.pixel_ranges_union = pixel_ranges_union |
There was a problem hiding this comment.
Maybe add a hpgeom version check here? I guess it shouldn't matter, but just in case the implementations diverge?
There was a problem hiding this comment.
Oh I'm going to make an hpgeom release and make that lower-limit for healsparse to keep them in sync. I'm also going to remove these temporary copies from healsparse (they are flagged DO NOT MERGE)
| else: | ||
| return hpg.pixel_ranges_to_pixels(pixel_ranges) | ||
|
|
||
| def add(self, geom): |
There was a problem hiding this comment.
Maybe change to append since add might be confusing with the sum operation?
| else: | ||
| return hpg.pixel_ranges_to_pixels(pixel_ranges) | ||
|
|
||
| def add(self, geom): |
There was a problem hiding this comment.
same comment as with the intersection -- maybe use append rather than add?
There was a problem hiding this comment.
This makes sense. I'll make that change.
No description provided.